Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 969173002: Add remoting and PPAPI tests to GN build (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add remoting and PPAPI tests to GN build Reland of https://codereview.chromium.org/961323004 TBR=dpranke Committed: https://crrev.com/31f4de692fea12661a046a0fc8d091ff6f04654d Cr-Commit-Position: refs/heads/master@{#319080}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merge #

Patch Set 4 : Windows #

Patch Set 5 : merge #

Patch Set 6 : Windows #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1135 lines, -217 lines) Patch
M BUILD.gn View 2 3 3 chunks +4 lines, -2 lines 0 comments Download
A build/config/linux/gtk/BUILD.gn View 1 chunk +42 lines, -0 lines 0 comments Download
M build/toolchain/win/midl.gni View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 3 chunks +2 lines, -17 lines 0 comments Download
M ppapi/BUILD.gn View 2 chunks +75 lines, -1 line 0 comments Download
M ppapi/ppapi_host.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 4 chunks +4 lines, -0 lines 0 comments Download
A remoting/BUILD.gn View 1 2 3 4 5 6 1 chunk +114 lines, -0 lines 0 comments Download
M remoting/base/BUILD.gn View 1 2 3 4 5 6 2 chunks +41 lines, -9 lines 0 comments Download
M remoting/client/BUILD.gn View 1 chunk +35 lines, -11 lines 0 comments Download
M remoting/client/plugin/BUILD.gn View 2 chunks +14 lines, -7 lines 0 comments Download
A remoting/codec/BUILD.gn View 1 chunk +47 lines, -0 lines 0 comments Download
M remoting/host/BUILD.gn View 1 2 3 4 5 5 chunks +235 lines, -16 lines 0 comments Download
M remoting/host/host_event_logger_win.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +10 lines, -14 lines 0 comments Download
A remoting/host/native_messaging/BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download
A remoting/host/setup/BUILD.gn View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A remoting/host/win/get_clsids.py View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 2 3 4 3 chunks +67 lines, -7 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M remoting/remoting_host.gypi View 1 2 3 chunks +4 lines, -30 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 2 3 4 1 chunk +35 lines, -1 line 0 comments Download
M remoting/remoting_host_win.gypi View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
A remoting/remoting_locales.gni View 1 2 3 4 1 chunk +104 lines, -0 lines 0 comments Download
M remoting/remoting_locales.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/remoting_srcs.gni View 1 chunk +14 lines, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 4 4 chunks +6 lines, -0 lines 0 comments Download
M remoting/resources/BUILD.gn View 1 2 3 2 chunks +2 lines, -95 lines 0 comments Download
A remoting/tools/build/message_compiler.gni View 1 2 3 4 5 6 1 chunk +51 lines, -0 lines 0 comments Download
A remoting/tools/build/message_compiler.py View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download
A remoting/tools/build/remoting_localize.gni View 1 2 3 4 5 6 1 chunk +113 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
This removes it from Windows, there is some extra work required
5 years, 9 months ago (2015-03-02 23:14:13 UTC) #2
Dirk Pranke
lgtm
5 years, 9 months ago (2015-03-02 23:21:37 UTC) #3
brettw
PTAL, this patch was reverted before. I had to do a bunch of Windows stuff ...
5 years, 9 months ago (2015-03-04 00:04:06 UTC) #5
brettw
Old checkin is in patch set 1 FYI.
5 years, 9 months ago (2015-03-04 00:04:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969173002/120001
5 years, 9 months ago (2015-03-04 17:21:00 UTC) #9
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 9 months ago (2015-03-04 17:24:54 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 17:25:51 UTC) #11
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/31f4de692fea12661a046a0fc8d091ff6f04654d
Cr-Commit-Position: refs/heads/master@{#319080}

Powered by Google App Engine
This is Rietveld 408576698