Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 961323004: Add remoting and PPAPI tests to GN build (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add remoting and PPAPI tests to GN build Reland of https://codereview.chromium.org/965633002/ TBR=dpranke Committed: https://crrev.com/66c53eef76f7dff97b1bc76d51740c3a9c07844f Cr-Commit-Position: refs/heads/master@{#318756}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : reverse condition #

Patch Set 4 : fix mac #

Patch Set 5 : #

Patch Set 6 : sync tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+705 lines, -120 lines) Patch
M BUILD.gn View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
A build/config/linux/gtk/BUILD.gn View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 3 chunks +2 lines, -17 lines 0 comments Download
M ppapi/BUILD.gn View 2 chunks +75 lines, -1 line 0 comments Download
M ppapi/ppapi_host.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 4 chunks +4 lines, -0 lines 0 comments Download
A remoting/BUILD.gn View 1 chunk +104 lines, -0 lines 0 comments Download
M remoting/base/BUILD.gn View 1 2 3 4 5 2 chunks +39 lines, -9 lines 0 comments Download
M remoting/client/BUILD.gn View 1 chunk +35 lines, -11 lines 0 comments Download
M remoting/client/plugin/BUILD.gn View 2 chunks +14 lines, -7 lines 0 comments Download
A remoting/codec/BUILD.gn View 1 chunk +47 lines, -0 lines 0 comments Download
M remoting/host/BUILD.gn View 1 2 3 4 chunks +145 lines, -19 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +10 lines, -14 lines 0 comments Download
A remoting/host/native_messaging/BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download
A remoting/host/setup/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
M remoting/protocol/BUILD.gn View 3 chunks +68 lines, -7 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/remoting_host.gypi View 3 chunks +4 lines, -30 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +35 lines, -1 line 0 comments Download
M remoting/remoting_nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/remoting_srcs.gni View 1 chunk +14 lines, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 4 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
brettw
Fix is in patch 1
5 years, 9 months ago (2015-02-28 00:09:38 UTC) #2
Dirk Pranke
looks like you still missed something.
5 years, 9 months ago (2015-02-28 00:14:06 UTC) #3
brettw
I got the condition reversed. PTAL
5 years, 9 months ago (2015-02-28 00:17:16 UTC) #4
Dirk Pranke
rubber-stamp lgtm assuming you get something through the bots w/ the right CQ_EXTRA_TRYBOTS set
5 years, 9 months ago (2015-02-28 00:28:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961323004/80001
5 years, 9 months ago (2015-03-02 18:38:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/13598)
5 years, 9 months ago (2015-03-02 19:01:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961323004/100001
5 years, 9 months ago (2015-03-02 19:08:17 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 9 months ago (2015-03-02 21:09:02 UTC) #14
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/66c53eef76f7dff97b1bc76d51740c3a9c07844f Cr-Commit-Position: refs/heads/master@{#318756}
5 years, 9 months ago (2015-03-02 21:09:42 UTC) #15
cpu_(ooo_6.6-7.5)
5 years, 9 months ago (2015-03-02 22:25:00 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/968243004/ by cpu@chromium.org.

The reason for reverting is: broke windows GN builds as seen in

http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5206/steps...
.

Powered by Google App Engine
This is Rietveld 408576698