Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 969103003: Don't save duplicates of wallet addresses to local Autofill. (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't save duplicates of wallet addresses to local Autofill. Also, change name of {S,G}etAutofillServerProfiles to {S,G}etServerProfiles to better match {S,G}etServerCreditCards BUG=459741 Committed: https://crrev.com/1908eba98112e9f42f5337052841d52a492e3fbc Cr-Commit-Position: refs/heads/master@{#318955}

Patch Set 1 #

Patch Set 2 : git cl format #

Patch Set 3 : make test work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -42 lines) Patch
M components/autofill/core/browser/autofill_profile.cc View 1 2 1 chunk +9 lines, -11 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_service.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
5 years, 9 months ago (2015-03-03 00:30:22 UTC) #2
brettw
lgtm
5 years, 9 months ago (2015-03-03 23:01:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969103003/40001
5 years, 9 months ago (2015-03-03 23:02:41 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-03 23:08:37 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 23:09:25 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1908eba98112e9f42f5337052841d52a492e3fbc
Cr-Commit-Position: refs/heads/master@{#318955}

Powered by Google App Engine
This is Rietveld 408576698