components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc - Issue 969103003: Don't save duplicates of wallet addresses to local Autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

Issue 969103003: Don't save duplicates of wallet addresses to local Autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make test work Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/autofill_table_unittest.cc ('k') | components/autofill/core/browser/webdata/autofill_webdata.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

diff --git a/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc b/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

index 7be33a99e5fa9022648055d0beca06cee627428b..4a8e60fd82f432483d11180c4c3cd65d1e2d8386 100644

--- a/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

+++ b/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

@@ -260,10 +260,8 @@ syncer::SyncMergeResult AutofillWalletSyncableService::SetSyncData(

&AutofillTable::SetServerCreditCards,

&prev_card_count);

bool changed_addresses = SetDataIfChanged(

- table, wallet_addresses,

- &AutofillTable::GetAutofillServerProfiles,

- &AutofillTable::SetAutofillServerProfiles,

- &prev_address_count);

+ table, wallet_addresses, &AutofillTable::GetServerProfiles,

+ &AutofillTable::SetServerProfiles, &prev_address_count);

syncer::SyncMergeResult merge_result(syncer::AUTOFILL_WALLET_DATA);

merge_result.set_num_items_before_association(