Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 968163003: Rename WorkerPermissionClient and friends to WorkerContentSettingsClient. (Closed)

Created:
5 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename WorkerPermissionClient and friends to WorkerContentSettingsClient. This CL is keeping WebWorkerPermissionClient and its proxy alive to prevent Chromium build to break. This is part of a suite of three CLs: 1. <this> 2. https://codereview.chromium.org/968983002 3. https://codereview.chromium.org/968203002 BUG=462255 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191193 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191497

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -238 lines) Patch
M Source/web/IndexedDBClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/LocalFileSystemClient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/web/WorkerContentSettingsClient.h View 2 chunks +12 lines, -12 lines 0 comments Download
A + Source/web/WorkerContentSettingsClient.cpp View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/web/WorkerGlobalScopeProxyProviderImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D Source/web/WorkerPermissionClient.h View 1 chunk +0 lines, -67 lines 0 comments Download
D Source/web/WorkerPermissionClient.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
M Source/web/web.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebEmbeddedWorker.h View 2 chunks +4 lines, -4 lines 0 comments Download
M public/web/WebFrameClient.h View 1 3 chunks +8 lines, -1 line 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebSharedWorkerClient.h View 3 chunks +9 lines, -3 lines 0 comments Download
A public/web/WebWorkerContentSettingsClientProxy.h View 1 chunk +43 lines, -0 lines 0 comments Download
M public/web/WebWorkerPermissionClientProxy.h View 1 chunk +2 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mlamouri (slow - plz ping)
5 years, 9 months ago (2015-03-02 15:23:45 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-03 13:40:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968163003/1
5 years, 9 months ago (2015-03-03 13:44:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191193
5 years, 9 months ago (2015-03-03 15:04:06 UTC) #6
enne (OOO)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/973103003/ by enne@chromium.org. ...
5 years, 9 months ago (2015-03-03 18:06:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968163003/20001
5 years, 9 months ago (2015-03-07 15:15:37 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 22:43:27 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191497

Powered by Google App Engine
This is Rietveld 408576698