Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 968813002: Standardize struct public member variables in ServiceProcessState::StateData (Closed)

Created:
5 years, 9 months ago by qi1988.yang
Modified:
5 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Standardize struct public member variables in ServiceProcessState::StateData Fix the TODO add by jhawkins. Struct data members do not have the trailing underscores that data members in class have. BUG= Committed: https://crrev.com/cd95dda367a2ca22779fb142f58ed3f70c26bb4d Cr-Commit-Position: refs/heads/master@{#319007}

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -42 lines) Patch
M chrome/common/service_process_util_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_mac.mm View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/service_process_util_posix.h View 1 chunk +9 lines, -13 lines 0 comments Download
M chrome/common/service_process_util_posix.cc View 1 6 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
qi1988.yang
PTAL,thanks!
5 years, 9 months ago (2015-03-02 07:04:51 UTC) #2
qi1988.yang
5 years, 9 months ago (2015-03-02 08:04:55 UTC) #4
James Hawkins
https://codereview.chromium.org/968813002/diff/1/chrome/common/service_process_util_mac.mm File chrome/common/service_process_util_mac.mm (left): https://codereview.chromium.org/968813002/diff/1/chrome/common/service_process_util_mac.mm#oldcode320 chrome/common/service_process_util_mac.mm:320: executable_path, Please don't change the style of the original ...
5 years, 9 months ago (2015-03-02 15:36:28 UTC) #5
qi1988.yang
https://codereview.chromium.org/968813002/diff/1/chrome/common/service_process_util_mac.mm File chrome/common/service_process_util_mac.mm (left): https://codereview.chromium.org/968813002/diff/1/chrome/common/service_process_util_mac.mm#oldcode320 chrome/common/service_process_util_mac.mm:320: executable_path, On 2015/03/02 15:36:27, James Hawkins wrote: > Please ...
5 years, 9 months ago (2015-03-03 05:59:20 UTC) #6
James Hawkins
lgtm
5 years, 9 months ago (2015-03-03 16:20:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968813002/20001
5 years, 9 months ago (2015-03-04 01:49:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 02:42:27 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 02:43:28 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd95dda367a2ca22779fb142f58ed3f70c26bb4d
Cr-Commit-Position: refs/heads/master@{#319007}

Powered by Google App Engine
This is Rietveld 408576698