Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4769)

Unified Diff: chrome/common/service_process_util_posix.h

Issue 968813002: Standardize struct public member variables in ServiceProcessState::StateData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/service_process_util_mac.mm ('k') | chrome/common/service_process_util_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/service_process_util_posix.h
diff --git a/chrome/common/service_process_util_posix.h b/chrome/common/service_process_util_posix.h
index 116437428188a86d0fa91cf3b236caf83726676d..16031e6d61198f83c1370ebf57a74ffaf7fb2b63 100644
--- a/chrome/common/service_process_util_posix.h
+++ b/chrome/common/service_process_util_posix.h
@@ -64,25 +64,21 @@ struct ServiceProcessState::StateData
// to be monitoring it.
void SignalReady(base::WaitableEvent* signal, bool* success);
-
- // TODO(jhawkins): Either make this a class or rename these public member
- // variables to remove the trailing underscore.
-
#if defined(OS_MACOSX)
bool WatchExecutable();
- base::ScopedCFTypeRef<CFDictionaryRef> launchd_conf_;
- base::FilePathWatcher executable_watcher_;
+ base::ScopedCFTypeRef<CFDictionaryRef> launchd_conf;
+ base::FilePathWatcher executable_watcher;
#endif // OS_MACOSX
#if defined(OS_POSIX) && !defined(OS_MACOSX)
- scoped_ptr<MultiProcessLock> initializing_lock_;
- scoped_ptr<MultiProcessLock> running_lock_;
+ scoped_ptr<MultiProcessLock> initializing_lock;
+ scoped_ptr<MultiProcessLock> running_lock;
#endif
- scoped_ptr<ServiceProcessTerminateMonitor> terminate_monitor_;
- base::MessageLoopForIO::FileDescriptorWatcher watcher_;
- int sockets_[2];
- struct sigaction old_action_;
- bool set_action_;
+ scoped_ptr<ServiceProcessTerminateMonitor> terminate_monitor;
+ base::MessageLoopForIO::FileDescriptorWatcher watcher;
+ int sockets[2];
+ struct sigaction old_action;
+ bool set_action;
protected:
friend class base::RefCountedThreadSafe<ServiceProcessState::StateData>;
« no previous file with comments | « chrome/common/service_process_util_mac.mm ('k') | chrome/common/service_process_util_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698