Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 968583002: bindings: Supports conditionally-enabled accessors. (Closed)

Created:
5 years, 9 months ago by Yuki
Modified:
5 years, 9 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bindings: Supports conditionally-enabled accessors. - Adds V8DOMConfiguration::installAccessor (prototype object version). - Renames parameter names to be consistent. ObjectTemplate => instanceTemplate or prototypeTemplate Object => instance or prototype ObjectOrTemplate => instanceOrTemplate or prototypeOrTemplate BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191182

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -75 lines) Patch
M Source/bindings/core/v8/V8DOMConfiguration.h View 4 chunks +11 lines, -9 lines 0 comments Download
M Source/bindings/core/v8/V8DOMConfiguration.cpp View 8 chunks +59 lines, -46 lines 6 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +5 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Yuki
Could you review this CL?
5 years, 9 months ago (2015-02-28 09:28:50 UTC) #2
haraken
LGTM https://codereview.chromium.org/968583002/diff/1/Source/bindings/core/v8/V8DOMConfiguration.cpp File Source/bindings/core/v8/V8DOMConfiguration.cpp (right): https://codereview.chromium.org/968583002/diff/1/Source/bindings/core/v8/V8DOMConfiguration.cpp#newcode40 Source/bindings/core/v8/V8DOMConfiguration.cpp:40: void installAttributeInternal(v8::Isolate* isolate, v8::Handle<ObjectOrTemplate> instanceOrTemplate, v8::Handle<ObjectOrTemplate> prototypeOrTemplate, const ...
5 years, 9 months ago (2015-02-28 15:14:00 UTC) #3
bashi
https://codereview.chromium.org/968583002/diff/1/Source/bindings/core/v8/V8DOMConfiguration.cpp File Source/bindings/core/v8/V8DOMConfiguration.cpp (right): https://codereview.chromium.org/968583002/diff/1/Source/bindings/core/v8/V8DOMConfiguration.cpp#newcode67 Source/bindings/core/v8/V8DOMConfiguration.cpp:67: v8::Local<v8::FunctionTemplate> functionOrTemplate(v8::Isolate* isolate, v8::FunctionCallback callback, const WrapperTypeInfo* wrapperTypeInfo, v8::Local<v8::Signature> ...
5 years, 9 months ago (2015-03-02 03:00:08 UTC) #5
Yuki
https://codereview.chromium.org/968583002/diff/1/Source/bindings/core/v8/V8DOMConfiguration.cpp File Source/bindings/core/v8/V8DOMConfiguration.cpp (right): https://codereview.chromium.org/968583002/diff/1/Source/bindings/core/v8/V8DOMConfiguration.cpp#newcode40 Source/bindings/core/v8/V8DOMConfiguration.cpp:40: void installAttributeInternal(v8::Isolate* isolate, v8::Handle<ObjectOrTemplate> instanceOrTemplate, v8::Handle<ObjectOrTemplate> prototypeOrTemplate, const V8DOMConfiguration::AttributeConfiguration& ...
5 years, 9 months ago (2015-03-03 07:11:47 UTC) #6
Yuki
As far as I checked, the only instance of use of PerContextEnabled and v8::Object-based installAttribute ...
5 years, 9 months ago (2015-03-03 07:59:35 UTC) #7
haraken
Discussed offline and we plan to remove [PerContextEnabled]. Either way this CL LGTM.
5 years, 9 months ago (2015-03-03 08:18:30 UTC) #8
Yuki
Let me commit this CL first. I'll work on the rest part in follow-up CLs.
5 years, 9 months ago (2015-03-03 08:36:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968583002/1
5 years, 9 months ago (2015-03-03 08:40:09 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 10:01:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191182

Powered by Google App Engine
This is Rietveld 408576698