Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: Source/bindings/core/v8/V8DOMConfiguration.h

Issue 968583002: bindings: Supports conditionally-enabled accessors. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8DOMConfiguration.h
diff --git a/Source/bindings/core/v8/V8DOMConfiguration.h b/Source/bindings/core/v8/V8DOMConfiguration.h
index d54bde35354be0f41c3185080e08752528d0c051..6fa7b4f383aff53687827690c117bdccd186a9f5 100644
--- a/Source/bindings/core/v8/V8DOMConfiguration.h
+++ b/Source/bindings/core/v8/V8DOMConfiguration.h
@@ -68,11 +68,11 @@ public:
InstanceOrPrototypeConfiguration instanceOrPrototypeConfiguration;
};
- static void installAttributes(v8::Isolate*, v8::Handle<v8::ObjectTemplate> instanceTemplate, v8::Handle<v8::ObjectTemplate> prototype, const AttributeConfiguration*, size_t attributeCount);
+ static void installAttributes(v8::Isolate*, v8::Handle<v8::ObjectTemplate> instanceTemplate, v8::Handle<v8::ObjectTemplate> prototypeTemplate, const AttributeConfiguration*, size_t attributeCount);
- static void installAttribute(v8::Isolate*, v8::Handle<v8::ObjectTemplate> instanceTemplate, v8::Handle<v8::ObjectTemplate> prototype, const AttributeConfiguration&);
+ static void installAttribute(v8::Isolate*, v8::Handle<v8::ObjectTemplate> instanceTemplate, v8::Handle<v8::ObjectTemplate> prototypeTemplate, const AttributeConfiguration&);
- static void installAttribute(v8::Isolate*, v8::Handle<v8::Object> instanceTemplate, v8::Handle<v8::Object> prototype, const AttributeConfiguration&);
+ static void installAttribute(v8::Isolate*, v8::Handle<v8::Object> instance, v8::Handle<v8::Object> prototype, const AttributeConfiguration&);
// AccessorConfiguration translates into calls to SetAccessorProperty()
// on prototype ObjectTemplate.
@@ -88,9 +88,11 @@ public:
ExposeConfiguration exposeConfiguration;
};
- static void installAccessors(v8::Isolate*, v8::Handle<v8::ObjectTemplate> prototype, v8::Handle<v8::Signature>, const AccessorConfiguration*, size_t accessorCount);
+ static void installAccessors(v8::Isolate*, v8::Handle<v8::ObjectTemplate> prototypeTemplate, v8::Handle<v8::Signature>, const AccessorConfiguration*, size_t accessorCount);
- static void installAccessor(v8::Isolate*, v8::Handle<v8::ObjectTemplate> prototype, v8::Handle<v8::Signature>, const AccessorConfiguration&);
+ static void installAccessor(v8::Isolate*, v8::Handle<v8::ObjectTemplate> prototypeTemplate, v8::Handle<v8::Signature>, const AccessorConfiguration&);
+
+ static void installAccessor(v8::Isolate*, v8::Handle<v8::Object> prototype, const AccessorConfiguration&);
enum ConstantType {
ConstantTypeShort,
@@ -121,11 +123,11 @@ public:
// installConstantWithGetter is used when some C++ code needs to be executed
// when the constant is accessed, e.g. to handle deprecation or measuring
// usage. The property appears the same to scripts, but is slower to access.
- static void installConstants(v8::Isolate*, v8::Handle<v8::FunctionTemplate> functionDescriptor, v8::Handle<v8::ObjectTemplate> prototype, const ConstantConfiguration*, size_t constantCount);
+ static void installConstants(v8::Isolate*, v8::Handle<v8::FunctionTemplate> functionDescriptor, v8::Handle<v8::ObjectTemplate> prototypeTemplate, const ConstantConfiguration*, size_t constantCount);
- static void installConstant(v8::Isolate*, v8::Handle<v8::FunctionTemplate> functionDescriptor, v8::Handle<v8::ObjectTemplate> prototype, const ConstantConfiguration&);
+ static void installConstant(v8::Isolate*, v8::Handle<v8::FunctionTemplate> functionDescriptor, v8::Handle<v8::ObjectTemplate> prototypeTemplate, const ConstantConfiguration&);
- static void installConstantWithGetter(v8::Isolate*, v8::Handle<v8::FunctionTemplate> functionDescriptor, v8::Handle<v8::ObjectTemplate> prototype, const char* name, v8::AccessorGetterCallback);
+ static void installConstantWithGetter(v8::Isolate*, v8::Handle<v8::FunctionTemplate> functionDescriptor, v8::Handle<v8::ObjectTemplate> prototypeTemplate, const char* name, v8::AccessorGetterCallback);
// MethodConfiguration translates into calls to Set() for setting up an
// object's callbacks. It sets the method on both the FunctionTemplate or
@@ -158,7 +160,7 @@ public:
ExposeConfiguration exposeConfiguration;
};
- static void installMethods(v8::Isolate*, v8::Handle<v8::ObjectTemplate> prototype, v8::Handle<v8::Signature>, v8::PropertyAttribute, const MethodConfiguration*, size_t callbackCount);
+ static void installMethods(v8::Isolate*, v8::Handle<v8::ObjectTemplate> prototypeTemplate, v8::Handle<v8::Signature>, v8::PropertyAttribute, const MethodConfiguration*, size_t callbackCount);
static void installMethod(v8::Isolate*, v8::Handle<v8::FunctionTemplate>, v8::Handle<v8::Signature>, v8::PropertyAttribute, const MethodConfiguration&);
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8DOMConfiguration.cpp » ('j') | Source/bindings/core/v8/V8DOMConfiguration.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698