[bindings] Support extended attribute '[CallWith=ScriptState ]' for getter/setter/deleter.

[bindings] Support extended attribute '[CallWith=ScriptState ]' for getter/setter/deleter.

This CL adds the support of CallWith=ScriptState extended attribute defined on getter/setter/deleter.

R=jl@opera.com, haraken@chromium.org, yukishiino@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191351

[vivekg, 2015-03-05 05:24:44]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-03-05 05:24:44]

PTAL, thanks.

[vivekg, 2015-03-05 05:28:07]

vivekg@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2015-03-05 05:56:13]

https://codereview.chromium.org/968573004/diff/1/Source/bindings/scripts/v8_i...
File Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/968573004/diff/1/Source/bindings/scripts/v8_i...
Source/bindings/scripts/v8_interface.py:1241: is_call_with_script_state = True

Use v8_utilities.has_extended_attribute_value(attribute, 'CallWith',
'ScriptState').

The same comment for other parts in this CL.

https://codereview.chromium.org/968573004/diff/1/Source/bindings/templates/in...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/968573004/diff/1/Source/bindings/templates/in...
Source/bindings/templates/interface.cpp:15: {# [CallWith=ScriptState] #}

Nit: Remove this comment.

https://codereview.chromium.org/968573004/diff/1/Source/bindings/templates/in...
Source/bindings/templates/interface.cpp:22: {% set getter_arguments =
getter_arguments + ['exceptionState'] %}

You can do something like:

{% set getter_arguments = ['index'] %}
{% if getter.is_call_with_script_state %}
{% set getter_arguments = ['scriptState'] + getter_arguments %}
ScriptState* scriptState = ScriptState::current(info.GetIsolate());
{% endif %}
{% if getter.is_raises_exception %}
{% set getter_arguments = getter_arguments + ['exceptionState'] %}
{% endif %}

Ditto for the other parts in this file.

[vivekg, 2015-03-05 06:16:36]

On 2015/03/05 at 05:56:13, haraken wrote:
>
https://codereview.chromium.org/968573004/diff/1/Source/bindings/scripts/v8_i...
> File Source/bindings/scripts/v8_interface.py (right):
> 
>
https://codereview.chromium.org/968573004/diff/1/Source/bindings/scripts/v8_i...
> Source/bindings/scripts/v8_interface.py:1241: is_call_with_script_state = True
> 
> Use v8_utilities.has_extended_attribute_value(attribute, 'CallWith',
'ScriptState').
> 
> The same comment for other parts in this CL.
> 
>
https://codereview.chromium.org/968573004/diff/1/Source/bindings/templates/in...
> File Source/bindings/templates/interface.cpp (right):
> 
>
https://codereview.chromium.org/968573004/diff/1/Source/bindings/templates/in...
> Source/bindings/templates/interface.cpp:15: {# [CallWith=ScriptState] #}
> 
> Nit: Remove this comment.
> 
>
https://codereview.chromium.org/968573004/diff/1/Source/bindings/templates/in...
> Source/bindings/templates/interface.cpp:22: {% set getter_arguments =
getter_arguments + ['exceptionState'] %}
> 
> You can do something like:
> 
> {% set getter_arguments = ['index'] %}
> {% if getter.is_call_with_script_state %}
> {% set getter_arguments = ['scriptState'] + getter_arguments %}
> ScriptState* scriptState = ScriptState::current(info.GetIsolate());
> {% endif %}
> {% if getter.is_raises_exception %}
> {% set getter_arguments = getter_arguments + ['exceptionState'] %}
> {% endif %}
> 
> Ditto for the other parts in this file.

Done, thank you. PTAL.

[Jens Widell, 2015-03-05 07:18:07]

LGTM

https://codereview.chromium.org/968573004/diff/20001/Source/bindings/scripts/...
File Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/968573004/diff/20001/Source/bindings/scripts/...
Source/bindings/scripts/v8_interface.py:1269: 'is_call_with_script_state':
is_call_with_script_state,
Nit: Move up a bit; the list should be sorted.

https://codereview.chromium.org/968573004/diff/20001/Source/bindings/scripts/...
Source/bindings/scripts/v8_interface.py:1298: 'is_call_with_script_state':
is_call_with_script_state,
Nit: Move up a bit; the list should be sorted.

https://codereview.chromium.org/968573004/diff/20001/Source/bindings/scripts/...
Source/bindings/scripts/v8_interface.py:1315: 'is_call_with_script_state':
is_call_with_script_state,
Nit: Move up a bit; the list should be sorted.

[vivekg, 2015-03-05 07:24:05]

On 2015/03/05 at 07:18:07, jl wrote:
> LGTM
> 
>
https://codereview.chromium.org/968573004/diff/20001/Source/bindings/scripts/...
> File Source/bindings/scripts/v8_interface.py (right):
> 
>
https://codereview.chromium.org/968573004/diff/20001/Source/bindings/scripts/...
> Source/bindings/scripts/v8_interface.py:1269: 'is_call_with_script_state':
is_call_with_script_state,
> Nit: Move up a bit; the list should be sorted.
> 
>
https://codereview.chromium.org/968573004/diff/20001/Source/bindings/scripts/...
> Source/bindings/scripts/v8_interface.py:1298: 'is_call_with_script_state':
is_call_with_script_state,
> Nit: Move up a bit; the list should be sorted.
> 
>
https://codereview.chromium.org/968573004/diff/20001/Source/bindings/scripts/...
> Source/bindings/scripts/v8_interface.py:1315: 'is_call_with_script_state':
is_call_with_script_state,
> Nit: Move up a bit; the list should be sorted.

Thanks.

[vivekg, 2015-03-05 07:27:03]

The CQ bit was checked by vivekg@chromium.org

[vivekg, 2015-03-05 07:27:04]

The patchset sent to the CQ was uploaded after l-g-t-m from jl@opera.com
Link to the patchset: https://codereview.chromium.org/968573004/#ps40001 (title:
"Patch for landing.")

[Yuki, 2015-03-05 07:36:44]

lgtm

[commit-bot: I haz the power, 2015-03-05 07:37:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/968573004/40001

[haraken, 2015-03-05 08:53:52]

LGTM

[commit-bot: I haz the power, 2015-03-05 09:01:27]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191351