[bindings] Support extended attribute '[CallWith=ScriptState ]' for getter/setter/deleter.

Source/bindings/templates/interface.cpp

 {% extends 'interface_base.cpp' %}
 
 
 {##############################################################################}
 {% block indexed_property_getter %}
 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
 {% set getter = indexed_property_getter %}
 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
     {% if getter.is_raises_exception %}
     ExceptionState exceptionState(ExceptionState::IndexedGetterContext, "{{interface_name}}", info.Holder(), info.GetIsolate());
     {% endif %}
+    {% if getter.is_call_with_script_state %}
+    {# [CallWith=ScriptState] #}

[haraken, 2015/03/05 05:56:13]

Nit: Remove this comment.

+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    {% endif %}
     {% set getter_name = getter.name or 'anonymousIndexedGetter' %}
-    {% set getter_arguments = ['index', 'exceptionState']
-           if getter.is_raises_exception else ['index'] %}
+    {% set getter_arguments = ['scriptState', 'index']
+           if getter.is_call_with_script_state else ['index'] %}
+    {% if getter.is_raises_exception %}
+    {% set getter_arguments = getter_arguments + ['exceptionState'] %}

[haraken, 2015/03/05 05:56:13]

You can do something like:

{% set getter_arguments = ['index'] %}
{% if getter.is_call_with_script_state %}
{% set getter_arguments = ['scriptState'] + getter_arguments %}
ScriptState* scriptState = ScriptState::current(info.GetIsolate());
{% endif %}
{% if getter.is_raises_exception %}
{% set getter_arguments = getter_arguments + ['exceptionState'] %}
{% endif %}

Ditto for the other parts in this file.

+    {% endif %}
     {{getter.cpp_type}} result = impl->{{getter_name}}({{getter_arguments | join(', ')}});
     {% if getter.is_raises_exception %}
     if (exceptionState.throwIfNeeded())
         return;
     {% endif %}
     if ({{getter.is_null_expression}})
         return;
     {{getter.v8_set_return_value}};
 }
 
@@ skipping 34 matching lines @@
     {% endif %}
     {% if setter.has_type_checking_interface %}
     {# Type checking for interface types (if interface not implemented, throw
        TypeError), per http://www.w3.org/TR/WebIDL/#es-interface #}
     if (!propertyValue{% if setter.is_nullable %} && !isUndefinedOrNull(v8Value){% endif %}) {
         exceptionState.throwTypeError("The provided value is not of type '{{setter.idl_type}}'.");
         exceptionState.throwIfNeeded();
         return;
     }
     {% endif %}
+    {% if setter.is_call_with_script_state %}
+    {# [CallWith=ScriptState] #}
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    {% endif %}
     {% set setter_name = setter.name or 'anonymousIndexedSetter' %}
-    {% set setter_arguments = ['index', 'propertyValue', 'exceptionState']
-           if setter.is_raises_exception else ['index', 'propertyValue'] %}
+    {% set setter_arguments = ['scriptState', 'index', 'propertyValue']
+           if setter.is_call_with_script_state else ['index', 'propertyValue'] %}
+    {% if setter.is_raises_exception %}
+    {% set setter_arguments = setter_arguments + ['exceptionState'] %}
+    {% endif %}
     bool result = impl->{{setter_name}}({{setter_arguments | join(', ')}});
     {% if setter.is_raises_exception %}
     if (exceptionState.throwIfNeeded())
         return;
     {% endif %}
     if (!result)
         return;
     v8SetReturnValue(info, v8Value);
 }
 
@@ skipping 23 matching lines @@
 {##############################################################################}
 {% block indexed_property_deleter %}
 {% if indexed_property_deleter and not indexed_property_deleter.is_custom %}
 {% set deleter = indexed_property_deleter %}
 static void indexedPropertyDeleter(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>& info)
 {
     {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
     {% if deleter.is_raises_exception %}
     ExceptionState exceptionState(ExceptionState::IndexedDeletionContext, "{{interface_name}}", info.Holder(), info.GetIsolate());
     {% endif %}
+    {% if deleter.is_call_with_script_state %}
+    {# [CallWith=ScriptState] #}
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    {% endif %}
     {% set deleter_name = deleter.name or 'anonymousIndexedDeleter' %}
-    {% set deleter_arguments = ['index', 'exceptionState']
-           if deleter.is_raises_exception else ['index'] %}
+    {% set deleter_arguments = ['scriptState', 'index']
+           if deleter.is_call_with_script_state else ['index'] %}
+    {% if deleter.is_raises_exception %}
+    {% set deleter_arguments = deleter_arguments + ['exceptionState'] %}
+    {% endif %}
     DeleteResult result = impl->{{deleter_name}}({{deleter_arguments | join(', ')}});
     {% if deleter.is_raises_exception %}
     if (exceptionState.throwIfNeeded())
         return;
     {% endif %}
     if (result != DeleteUnknownProperty)
         return v8SetReturnValueBool(info, result == DeleteSuccess);
 }
 
 {% endif %}
@@ skipping 34 matching lines @@
     if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(nameString).IsEmpty())
         return;
 
     {% endif %}
     {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
     AtomicString propertyName = toCoreAtomicString(nameString);
     {% if getter.is_raises_exception %}
     v8::String::Utf8Value namedProperty(nameString);
     ExceptionState exceptionState(ExceptionState::GetterContext, *namedProperty, "{{interface_name}}", info.Holder(), info.GetIsolate());
     {% endif %}
+    {% if getter.is_call_with_script_state %}
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    {% endif %}
     {% if getter.use_output_parameter_for_result %}
     {{getter.cpp_type}} result;
     {{getter.cpp_value}};
     {% else %}
     {{getter.cpp_type}} result = {{getter.cpp_value}};
     {% endif %}
     {% if getter.is_raises_exception %}
     if (exceptionState.throwIfNeeded())
         return;
     {% endif %}
@@ skipping 54 matching lines @@
     {{v8_value_to_local_cpp_value(setter) | indent}}
     {% if setter.has_type_checking_interface %}
     {# Type checking for interface types (if interface not implemented, throw
        TypeError), per http://www.w3.org/TR/WebIDL/#es-interface #}
     if (!propertyValue{% if setter.is_nullable %} && !isUndefinedOrNull(v8Value){% endif %}) {
         exceptionState.throwTypeError("The provided value is not of type '{{setter.idl_type}}'.");
         exceptionState.throwIfNeeded();
         return;
     }
     {% endif %}
+    {% if setter.is_call_with_script_state %}
+    {# [CallWith=ScriptState] #}
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    {% endif %}
     {% set setter_name = setter.name or 'anonymousNamedSetter' %}
     {% set setter_arguments =
-           ['propertyName', 'propertyValue', 'exceptionState']
-           if setter.is_raises_exception else
+           ['scriptState', 'propertyName', 'propertyValue']
+           if setter.is_call_with_script_state else
            ['propertyName', 'propertyValue'] %}
+    {% if setter.is_raises_exception %}
+    {% set setter_arguments =  setter_arguments + ['exceptionState'] %}
+    {% endif %}
     bool result = impl->{{setter_name}}({{setter_arguments | join(', ')}});
     {% if setter.is_raises_exception %}
     if (exceptionState.throwIfNeeded())
         return;
     {% endif %}
     if (!result)
         return;
     v8SetReturnValue(info, v8Value);
 }
 
@@ skipping 72 matching lines @@
 static void namedPropertyDeleter(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)
 {
     if (!name->IsString())
         return;
     {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
     AtomicString propertyName = toCoreAtomicString(name.As<v8::String>());
     {% if deleter.is_raises_exception %}
     v8::String::Utf8Value namedProperty(name);
     ExceptionState exceptionState(ExceptionState::DeletionContext, *namedProperty, "{{interface_name}}", info.Holder(), info.GetIsolate());
     {% endif %}
+    {% if deleter.is_call_with_script_state %}
+    {# [CallWith=ScriptState] #}
+    ScriptState* scriptState = ScriptState::current(info.GetIsolate());
+    {% endif %}
     {% set deleter_name = deleter.name or 'anonymousNamedDeleter' %}
-    {% set deleter_arguments = ['propertyName', 'exceptionState']
-           if deleter.is_raises_exception else ['propertyName'] %}
+    {% set deleter_arguments = ['scriptState', 'propertyName']
+           if deleter.is_call_with_script_state else ['propertyName'] %}
+    {% if deleter.is_raises_exception %}
+    {% set deleter_arguments = deleter_arguments + ['exceptionState'] %}
+    {% endif %}
     DeleteResult result = impl->{{deleter_name}}({{deleter_arguments | join(', ')}});
     {% if deleter.is_raises_exception %}
     if (exceptionState.throwIfNeeded())
         return;
     {% endif %}
     if (result != DeleteUnknownProperty)
         return v8SetReturnValueBool(info, result == DeleteSuccess);
 }
 
 {% endif %}
@@ skipping 631 matching lines @@
 }
 
 {% for method in methods if method.overloads and method.overloads.has_partial_overloads %}
 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInterface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
 {
     {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
 }
 {% endfor %}
 {% endif %}
 {% endblock %}