Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: net/quic/quic_protocol.h

Issue 968493002: Cleanup of QUIC's TransmissionInfo constructor to make more fields const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Fixing_bug_QUIC_prober_86703503
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_protocol.h
diff --git a/net/quic/quic_protocol.h b/net/quic/quic_protocol.h
index b68a9940b82f153713e29f349492d0b92cc6c61a..b1f4421cd55960b1ea4cad42a298840808114427 100644
--- a/net/quic/quic_protocol.h
+++ b/net/quic/quic_protocol.h
@@ -1017,17 +1017,17 @@ struct NET_EXPORT_PRIVATE TransmissionInfo {
TransmissionInfo(RetransmittableFrames* retransmittable_frames,
QuicSequenceNumberLength sequence_number_length,
TransmissionType transmission_type,
- QuicTime sent_time);
+ QuicTime sent_time,
+ QuicByteCount bytes_sent,
+ bool is_fec_packet);
RetransmittableFrames* retransmittable_frames;
- QuicSequenceNumberLength sequence_number_length;
- // Zero when the packet is serialized, non-zero once it's sent.
- QuicTime sent_time;
- // Zero when the packet is serialized, non-zero once it's sent.
+ const QuicSequenceNumberLength sequence_number_length;
+ const QuicTime sent_time;
QuicByteCount bytes_sent;
QuicPacketCount nack_count;
// Reason why this packet was transmitted.
- TransmissionType transmission_type;
+ const TransmissionType transmission_type;
// Stores the sequence numbers of all transmissions of this packet.
// Must always be nullptr or have multiple elements.
SequenceNumberList* all_transmissions;
@@ -1036,7 +1036,7 @@ struct NET_EXPORT_PRIVATE TransmissionInfo {
// True if the packet can never be acked, so it can be removed.
bool is_unackable;
// True if the packet is an FEC packet.
- bool is_fec_packet;
+ const bool is_fec_packet;
};
} // namespace net
« no previous file with comments | « no previous file | net/quic/quic_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698