Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: net/quic/quic_protocol.h

Issue 968493002: Cleanup of QUIC's TransmissionInfo constructor to make more fields const (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Fixing_bug_QUIC_prober_86703503
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/quic_protocol.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_PROTOCOL_H_ 5 #ifndef NET_QUIC_QUIC_PROTOCOL_H_
6 #define NET_QUIC_QUIC_PROTOCOL_H_ 6 #define NET_QUIC_QUIC_PROTOCOL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <limits> 9 #include <limits>
10 #include <list> 10 #include <list>
(...skipping 999 matching lines...) Expand 10 before | Expand all | Expand 10 after
1010 1010
1011 struct NET_EXPORT_PRIVATE TransmissionInfo { 1011 struct NET_EXPORT_PRIVATE TransmissionInfo {
1012 // Used by STL when assigning into a map. 1012 // Used by STL when assigning into a map.
1013 TransmissionInfo(); 1013 TransmissionInfo();
1014 1014
1015 // Constructs a Transmission with a new all_tranmissions set 1015 // Constructs a Transmission with a new all_tranmissions set
1016 // containing |sequence_number|. 1016 // containing |sequence_number|.
1017 TransmissionInfo(RetransmittableFrames* retransmittable_frames, 1017 TransmissionInfo(RetransmittableFrames* retransmittable_frames,
1018 QuicSequenceNumberLength sequence_number_length, 1018 QuicSequenceNumberLength sequence_number_length,
1019 TransmissionType transmission_type, 1019 TransmissionType transmission_type,
1020 QuicTime sent_time); 1020 QuicTime sent_time,
1021 QuicByteCount bytes_sent,
1022 bool is_fec_packet);
1021 1023
1022 RetransmittableFrames* retransmittable_frames; 1024 RetransmittableFrames* retransmittable_frames;
1023 QuicSequenceNumberLength sequence_number_length; 1025 const QuicSequenceNumberLength sequence_number_length;
1024 // Zero when the packet is serialized, non-zero once it's sent. 1026 const QuicTime sent_time;
1025 QuicTime sent_time;
1026 // Zero when the packet is serialized, non-zero once it's sent.
1027 QuicByteCount bytes_sent; 1027 QuicByteCount bytes_sent;
1028 QuicPacketCount nack_count; 1028 QuicPacketCount nack_count;
1029 // Reason why this packet was transmitted. 1029 // Reason why this packet was transmitted.
1030 TransmissionType transmission_type; 1030 const TransmissionType transmission_type;
1031 // Stores the sequence numbers of all transmissions of this packet. 1031 // Stores the sequence numbers of all transmissions of this packet.
1032 // Must always be nullptr or have multiple elements. 1032 // Must always be nullptr or have multiple elements.
1033 SequenceNumberList* all_transmissions; 1033 SequenceNumberList* all_transmissions;
1034 // In flight packets have not been abandoned or lost. 1034 // In flight packets have not been abandoned or lost.
1035 bool in_flight; 1035 bool in_flight;
1036 // True if the packet can never be acked, so it can be removed. 1036 // True if the packet can never be acked, so it can be removed.
1037 bool is_unackable; 1037 bool is_unackable;
1038 // True if the packet is an FEC packet. 1038 // True if the packet is an FEC packet.
1039 bool is_fec_packet; 1039 const bool is_fec_packet;
1040 }; 1040 };
1041 1041
1042 } // namespace net 1042 } // namespace net
1043 1043
1044 #endif // NET_QUIC_QUIC_PROTOCOL_H_ 1044 #endif // NET_QUIC_QUIC_PROTOCOL_H_
OLDNEW
« no previous file with comments | « no previous file | net/quic/quic_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698