Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 968463003: Make Chromoting browser tests pass again (Closed)

Created:
5 years, 9 months ago by kelvinp
Modified:
5 years, 9 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org, John Williams, Jamie
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Chromoting browser tests pass again Summary of changes: 1. Fix a bug in identity.js that breaks first run scenario of the v2 app, Previously, we are resetting the deferred object (the list of listeners) when auth is failed even when interactive is set to false, which always happened on first runs. At a result, when auth is completed, the listeners are not notified. This CL only clears the deferred object after it has notified its listeners. 2. Fix a missing parameter in session_connector_impl.js that causes It2Me to fail to connect. 3. Changes it2me_browser_test.js to match the changes in the identity API. BUG=462708 TEST=Browser test passes on swarming bots. https://chromium-swarm.appspot.com/user/task/25e6711d0deacc10 NOTRY=true Committed: https://crrev.com/5b7edf8068252334fa44d033e4e275121a5a1cc1 Cr-Commit-Position: refs/heads/master@{#318579}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -30 lines) Patch
M remoting/webapp/browser_test/it2me_browser_test.js View 5 chunks +13 lines, -25 lines 0 comments Download
M remoting/webapp/crd/js/identity.js View 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/session_connector_impl.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
kelvinp
PTAL
5 years, 9 months ago (2015-02-28 00:57:49 UTC) #3
garykac
lgtm
5 years, 9 months ago (2015-02-28 01:01:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968463003/20001
5 years, 9 months ago (2015-02-28 01:04:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/63187) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 9 months ago (2015-02-28 01:59:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968463003/20001
5 years, 9 months ago (2015-02-28 02:44:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-02-28 02:44:54 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 02:45:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b7edf8068252334fa44d033e4e275121a5a1cc1
Cr-Commit-Position: refs/heads/master@{#318579}

Powered by Google App Engine
This is Rietveld 408576698