Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: remoting/webapp/crd/js/identity.js

Issue 968463003: Make Chromoting browser tests pass again (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/identity.js
diff --git a/remoting/webapp/crd/js/identity.js b/remoting/webapp/crd/js/identity.js
index f17e9354f6a717d997489b25c769dbad709f9701..b2f2c5a3df3228195bb6893058ec34bdc16a2e33 100644
--- a/remoting/webapp/crd/js/identity.js
+++ b/remoting/webapp/crd/js/identity.js
@@ -195,14 +195,11 @@ remoting.Identity.prototype.getCachedUserFullName = function() {
*/
remoting.Identity.prototype.onAuthComplete_ = function(interactive, token) {
var authTokenDeferred = this.authTokenDeferred_;
- if (authTokenDeferred == null) {
- return;
- }
- this.authTokenDeferred_ = null;
// Pass the token to the callback(s) if it was retrieved successfully.
if (token) {
authTokenDeferred.resolve(token);
+ this.authTokenDeferred_ = null;
return;
}
@@ -214,6 +211,7 @@ remoting.Identity.prototype.onAuthComplete_ = function(interactive, token) {
: 'Unknown error.';
console.error(error_message);
authTokenDeferred.reject(remoting.Error.NOT_AUTHENTICATED);
+ this.authTokenDeferred_ = null;
return;
}
« no previous file with comments | « remoting/webapp/browser_test/it2me_browser_test.js ('k') | remoting/webapp/crd/js/session_connector_impl.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698