content: Remove use of GLImage from GpuMemoryBufferImpl.

content: Remove use of GLImage from GpuMemoryBufferImpl.

GpuMemoryBuffer implementations should not depend on
GLImage. This moves the capabilities and size checks
needed for compressed formats to the ImageFactory
interface.

BUG=462541
Committed: https://crrev.com/a68c262837f9d0be16b857dd5e6306a2ba0236f0
Cr-Commit-Position: refs/heads/master@{#318990}

[reveman, 2015-03-02 18:18:29]

reveman@chromium.org changed reviewers:
+ christiank@opera.com, piman@chromium.org

[piman, 2015-03-03 20:48:21]

lgtm

https://codereview.chromium.org/968283002/diff/1/content/common/gpu/client/gp...
File content/common/gpu/client/gpu_memory_buffer_impl.cc (left):

https://codereview.chromium.org/968283002/diff/1/content/common/gpu/client/gp...
content/common/gpu/client/gpu_memory_buffer_impl.cc:37:
DCHECK(gfx::GLImageMemory::ValidSize(size, format));
nit: it'd be nice to keep this DCHECK which is in the call stack of when the
buffer is originally created.

[reveman, 2015-03-03 23:46:27]

https://codereview.chromium.org/968283002/diff/1/content/common/gpu/client/gp...
File content/common/gpu/client/gpu_memory_buffer_impl.cc (left):

https://codereview.chromium.org/968283002/diff/1/content/common/gpu/client/gp...
content/common/gpu/client/gpu_memory_buffer_impl.cc:37:
DCHECK(gfx::GLImageMemory::ValidSize(size, format));
On 2015/03/03 20:48:21, piman (Very slow to review) wrote:
> nit: it'd be nice to keep this DCHECK which is in the call stack of when the
> buffer is originally created.

Added size checks to the GMB code. And validation on the browser side. It's not
required for security but if we're going to have a DCHECK on the client side
then I think we should have validation on the browser side too.

[reveman, 2015-03-03 23:46:30]

The CQ bit was checked by reveman@chromium.org

[reveman, 2015-03-03 23:46:31]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/968283002/#ps20001 (title:
"add size check to gmb code")

[commit-bot: I haz the power, 2015-03-03 23:47:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/968283002/20001

[piman, 2015-03-04 00:01:22]

On 2015/03/03 23:46:27, reveman wrote:
>
https://codereview.chromium.org/968283002/diff/1/content/common/gpu/client/gp...
> File content/common/gpu/client/gpu_memory_buffer_impl.cc (left):
> 
>
https://codereview.chromium.org/968283002/diff/1/content/common/gpu/client/gp...
> content/common/gpu/client/gpu_memory_buffer_impl.cc:37:
> DCHECK(gfx::GLImageMemory::ValidSize(size, format));
> On 2015/03/03 20:48:21, piman (Very slow to review) wrote:
> > nit: it'd be nice to keep this DCHECK which is in the call stack of when the
> > buffer is originally created.
> 
> Added size checks to the GMB code. And validation on the browser side. It's
not
> required for security but if we're going to have a DCHECK on the client side
> then I think we should have validation on the browser side too.

LGTM, thanks.

[commit-bot: I haz the power, 2015-03-04 01:24:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-04 01:25:25]

Patchset 2 (id:??) landed as
https://crrev.com/a68c262837f9d0be16b857dd5e6306a2ba0236f0
Cr-Commit-Position: refs/heads/master@{#318990}