content/common/gpu/client/command_buffer_proxy_impl.cc - Issue 968283002: content: Remove use of GLImage from GpuMemoryBufferImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/command_buffer_proxy_impl.cc

Issue 968283002: content: Remove use of GLImage from GpuMemoryBufferImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add size check to gmb code Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/gpu/browser_gpu_memory_buffer_manager.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/command_buffer_proxy_impl.cc

diff --git a/content/common/gpu/client/command_buffer_proxy_impl.cc b/content/common/gpu/client/command_buffer_proxy_impl.cc

index 75cffa2fdd0f5340391b23bbd493ab4b7bae6b19..8241812cc2af9aa068f6bce602727e67ecf841eb 100644

--- a/content/common/gpu/client/command_buffer_proxy_impl.cc

+++ b/content/common/gpu/client/command_buffer_proxy_impl.cc

@@ -371,6 +371,8 @@ int32_t CommandBufferProxyImpl::CreateImage(ClientBuffer buffer,

channel_->ShareGpuMemoryBufferToGpuProcess(gpu_memory_buffer->GetHandle(),

&requires_sync_point);

+ DCHECK(gpu::ImageFactory::IsImageSizeValidForGpuMemoryBufferFormat(

+ gfx::Size(width, height), gpu_memory_buffer->GetFormat()));

DCHECK(gpu::ImageFactory::IsImageFormatCompatibleWithGpuMemoryBufferFormat(

internalformat, gpu_memory_buffer->GetFormat()));

if (!Send(new GpuCommandBufferMsg_CreateImage(route_id_,

« no previous file with comments | « content/browser/gpu/browser_gpu_memory_buffer_manager.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl.cc » ('j') | no next file with comments »