Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 968213003: Don't hide the zoom icon when not at default zoom. (Closed)

Created:
5 years, 9 months ago by wjmaclean
Modified:
5 years, 2 months ago
CC:
chromium-reviews, erikchen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't hide the zoom icon when not at default zoom. This cl reverts a change made in https://codereview.chromium.org/952823004 Since this code is controlling the display of the zoom icon (not the bubble) we should not hide when not at default zoom level. BUG=462482 Committed: https://crrev.com/ba2ded87cb76cb26edaad3a6b21776744cf03d52 Cr-Commit-Position: refs/heads/master@{#318908}

Patch Set 1 #

Patch Set 2 : Add regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
wjmaclean
Apparently we shouldn't have remove this check, please take a look (*tiny* CL).
5 years, 9 months ago (2015-03-02 17:47:44 UTC) #2
rohitrao (ping after 24h)
lgtm
5 years, 9 months ago (2015-03-03 15:17:21 UTC) #4
rohitrao (ping after 24h)
Can we write a test for this?
5 years, 9 months ago (2015-03-03 15:17:39 UTC) #5
wjmaclean
On 2015/03/03 15:17:39, rohitrao wrote: > Can we write a test for this? I'll see ...
5 years, 9 months ago (2015-03-03 15:19:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968213003/20001
5 years, 9 months ago (2015-03-03 17:19:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 18:08:54 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ba2ded87cb76cb26edaad3a6b21776744cf03d52 Cr-Commit-Position: refs/heads/master@{#318908}
5 years, 9 months ago (2015-03-03 18:09:39 UTC) #11
rohitrao (ping after 24h)
5 years, 9 months ago (2015-03-03 18:34:45 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698