chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm - Issue 968213003: Don't hide the zoom icon when not at default zoom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

Issue 968213003: Don't hide the zoom icon when not at default zoom. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add regression test. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm b/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

index 8378993b42acf0d8b98143368c4714a60319d6c5..659f2a6e1a8744d6752b300a6add5d3bf94b5c9e 100644

--- a/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

+++ b/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

@@ -151,7 +151,7 @@ void ZoomDecoration::OnClose() {

// If the page is at default zoom then hiding the zoom decoration

// was suppressed while the bubble was open. Now that the bubble is

// closed the decoration can be hidden.

- if (IsVisible()) {

+ if (IsAtDefaultZoom() && IsVisible()) {

SetVisible(false);

owner_->OnDecorationsChanged();

}

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm » ('j') | no next file with comments »