Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 968133005: Trim the fat off SkPMFloat bench. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, msarett
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Trim the fat off SkPMFloat bench. This bench was ~75% overhead, ~25% good bench. It is now just about the opposite: about 30% of the runtime is loop and random number overhead, and about 70% of the time is spent doing SkPMColor <-> SkPMFloat work. BUG=skia: NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/60ff4582ae76aa131aeb20a3e16c89fa3a40a41c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M bench/PMFloatBench.cpp View 2 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mtklein_C
5 years, 9 months ago (2015-03-03 02:06:03 UTC) #2
reed1
lgtm
5 years, 9 months ago (2015-03-03 15:05:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968133005/1
5 years, 9 months ago (2015-03-03 15:07:03 UTC) #5
commit-bot: I haz the power
Presubmit check for 968133005-1 failed and returned exit status 1. Traceback (most recent call last): ...
5 years, 9 months ago (2015-03-03 15:07:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968133005/1
5 years, 9 months ago (2015-03-03 15:25:03 UTC) #9
commit-bot: I haz the power
Presubmit check for 968133005-1 failed and returned exit status 1. Traceback (most recent call last): ...
5 years, 9 months ago (2015-03-03 15:25:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968133005/1
5 years, 9 months ago (2015-03-03 15:48:03 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 16:03:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/60ff4582ae76aa131aeb20a3e16c89fa3a40a41c

Powered by Google App Engine
This is Rietveld 408576698