Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 967713002: fixes #69, avoid module name inside module scope (Closed)

Created:
5 years, 9 months ago by Jennifer Messerly
Modified:
5 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1027 lines, -1016 lines) Patch
M lib/src/codegen/js_codegen.dart View 9 chunks +23 lines, -12 lines 0 comments Download
M test/codegen/expect/BenchmarkBase/BenchmarkBase.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/codegen/expect/DeltaBlue/DeltaBlue.js View 7 chunks +35 lines, -35 lines 0 comments Download
M test/codegen/expect/_foreign_helper/_foreign_helper.js View 2 chunks +32 lines, -32 lines 0 comments Download
M test/codegen/expect/_interceptors/_interceptors.js View 5 chunks +44 lines, -44 lines 0 comments Download
M test/codegen/expect/_internal/_internal.js View 3 chunks +74 lines, -74 lines 0 comments Download
M test/codegen/expect/_isolate_helper/_isolate_helper.js View 36 chunks +80 lines, -80 lines 0 comments Download
M test/codegen/expect/_js_embedded_names/_js_embedded_names.js View 2 chunks +32 lines, -32 lines 0 comments Download
M test/codegen/expect/_js_helper/_js_helper.js View 19 chunks +269 lines, -269 lines 0 comments Download
M test/codegen/expect/_js_names/_js_names.js View 2 chunks +10 lines, -10 lines 0 comments Download
M test/codegen/expect/_js_primitives/_js_primitives.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen/expect/_native_typed_data/_native_typed_data.js View 2 chunks +22 lines, -22 lines 0 comments Download
M test/codegen/expect/async/async.js View 3 chunks +62 lines, -62 lines 0 comments Download
M test/codegen/expect/cascade/cascade.js View 2 chunks +9 lines, -9 lines 0 comments Download
M test/codegen/expect/collection/collection.js View 2 chunks +66 lines, -66 lines 0 comments Download
M test/codegen/expect/constructors/constructors.js View 2 chunks +17 lines, -17 lines 0 comments Download
M test/codegen/expect/convert/convert.js View 2 chunks +39 lines, -39 lines 0 comments Download
M test/codegen/expect/core/core.js View 2 chunks +70 lines, -70 lines 0 comments Download
M test/codegen/expect/dom/dom.js View 3 chunks +19 lines, -19 lines 0 comments Download
M test/codegen/expect/fieldtest/fieldtest.js View 4 chunks +15 lines, -15 lines 0 comments Download
M test/codegen/expect/html_input_a/html_input_a.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen/expect/html_input_b/html_input_b.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/html_input_c/html_input_c.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/html_input_d/html_input_d.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen/expect/html_input_e/html_input_e.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/isolate/isolate.js View 2 chunks +8 lines, -8 lines 0 comments Download
M test/codegen/expect/math/math.js View 2 chunks +29 lines, -29 lines 0 comments Download
M test/codegen/expect/methods/methods.js View 2 chunks +5 lines, -5 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.js View 4 chunks +30 lines, -30 lines 0 comments Download
M test/codegen/expect/typed_data/typed_data.js View 2 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 9 months ago (2015-02-27 23:13:39 UTC) #2
vsm
lgtm
5 years, 9 months ago (2015-03-02 13:23:11 UTC) #3
Jennifer Messerly
5 years, 9 months ago (2015-03-02 15:10:54 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
00a7dbb8efb3ba7d75a4d08dc3dc5f0a0da51b7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698