Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: pkg/analyzer/lib/src/analyzer_impl.dart

Issue 967703002: Avoid unnecessary parsing/resolution when running command line analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/ast.dart » ('j') | pkg/analyzer/lib/src/generated/engine.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/analyzer_impl.dart
diff --git a/pkg/analyzer/lib/src/analyzer_impl.dart b/pkg/analyzer/lib/src/analyzer_impl.dart
index f0cf30c18b35971ce06099ace650404f6b023f9a..2030b1737732b44a9d60f6183c8808bd621bd817 100644
--- a/pkg/analyzer/lib/src/analyzer_impl.dart
+++ b/pkg/analyzer/lib/src/analyzer_impl.dart
@@ -16,6 +16,7 @@ import 'package:analyzer/source/pub_package_map_provider.dart';
import 'package:analyzer/src/error_formatter.dart';
import 'package:analyzer/src/generated/java_core.dart' show JavaSystem;
import 'package:analyzer/src/generated/java_engine.dart';
+import 'package:analyzer/src/generated/utilities_general.dart';
import '../options.dart';
import 'generated/constant.dart';
@@ -25,7 +26,6 @@ import 'generated/error.dart';
import 'generated/java_io.dart';
import 'generated/sdk_io.dart';
import 'generated/source_io.dart';
-import 'package:analyzer/src/generated/utilities_general.dart';
DirectoryBasedDartSdk sdk;
@@ -157,9 +157,7 @@ class AnalyzerImpl {
Map<String, List<Folder>> packageMap = packageMapInfo.packageMap;
if (packageMap != null) {
resolvers.add(
- new PackageMapUriResolver(
- PhysicalResourceProvider.INSTANCE,
- packageMap));
+ new PackageMapUriResolver(PhysicalResourceProvider.INSTANCE, packageMap));
}
}
}
@@ -180,6 +178,8 @@ class AnalyzerImpl {
AnalysisOptionsImpl contextOptions = new AnalysisOptionsImpl();
contextOptions.cacheSize = _MAX_CACHE_SIZE;
contextOptions.hint = !options.disableHints;
+ contextOptions.analyzeFunctionBodiesPredicate =
+ _analyzeFunctionBodiesPredicate;
context.analysisOptions = contextOptions;
// Create and add a ChangeSet
@@ -257,6 +257,16 @@ class AnalyzerImpl {
});
}
+ bool _analyzeFunctionBodiesPredicate(Source source) {
+ if (source.uri.scheme == 'dart') {
+ return options.showSdkWarnings;
+ }
+ if (source.uri.scheme == 'package') {
+ return options.showPackageWarnings;
+ }
+ return true;
Brian Wilkerson 2015/02/27 23:52:05 This will need to be extended to account for the c
Paul Berry 2015/03/02 19:09:45 Ok, I've added a TODO.
+ }
+
/// The sync version of analysis.
ErrorSeverity _analyzeSync(int printMode) {
// don't try to analyze parts
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/ast.dart » ('j') | pkg/analyzer/lib/src/generated/engine.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698