Avoid unnecessary parsing/resolution when running command line analyzer.

pkg/analyzer/lib/src/analyzer_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_impl;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:io';
 
 import 'package:analyzer/file_system/file_system.dart' show Folder;
 import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:analyzer/source/package_map_provider.dart';
 import 'package:analyzer/source/package_map_resolver.dart';
 import 'package:analyzer/source/pub_package_map_provider.dart';
 import 'package:analyzer/src/error_formatter.dart';
 import 'package:analyzer/src/generated/java_core.dart' show JavaSystem;
 import 'package:analyzer/src/generated/java_engine.dart';
+import 'package:analyzer/src/generated/utilities_general.dart';
 
 import '../options.dart';
 import 'generated/constant.dart';
 import 'generated/element.dart';
 import 'generated/engine.dart';
 import 'generated/error.dart';
 import 'generated/java_io.dart';
 import 'generated/sdk_io.dart';
 import 'generated/source_io.dart';
-import 'package:analyzer/src/generated/utilities_general.dart';
 
 DirectoryBasedDartSdk sdk;
 
 /**
  * The maximum number of sources for which AST structures should be kept in the cache.
  */
 const int _MAX_CACHE_SIZE = 512;
 
 /// Analyzes single library [File].
 class AnalyzerImpl {
@@ skipping 111 matching lines @@
         packageDirectory = new JavaFile(options.packageRootPath);
         resolvers.add(new PackageUriResolver([packageDirectory]));
       } else {
         PubPackageMapProvider pubPackageMapProvider =
             new PubPackageMapProvider(PhysicalResourceProvider.INSTANCE, sdk);
         PackageMapInfo packageMapInfo = pubPackageMapProvider.computePackageMap(
             PhysicalResourceProvider.INSTANCE.getResource('.'));
         Map<String, List<Folder>> packageMap = packageMapInfo.packageMap;
         if (packageMap != null) {
           resolvers.add(
-              new PackageMapUriResolver(
-                  PhysicalResourceProvider.INSTANCE,
-                  packageMap));
+              new PackageMapUriResolver(PhysicalResourceProvider.INSTANCE, packageMap));
         }
       }
     }
     sourceFactory = new SourceFactory(resolvers);
     context = AnalysisEngine.instance.createAnalysisContext();
     context.sourceFactory = sourceFactory;
     Map<String, String> definedVariables = options.definedVariables;
     if (!definedVariables.isEmpty) {
       DeclaredVariables declaredVariables = context.declaredVariables;
       definedVariables.forEach((String variableName, String value) {
         declaredVariables.define(variableName, value);
       });
     }
     // Uncomment the following to have errors reported on stdout and stderr
     AnalysisEngine.instance.logger = new StdLogger(options.log);
 
     // set options for context
     AnalysisOptionsImpl contextOptions = new AnalysisOptionsImpl();
     contextOptions.cacheSize = _MAX_CACHE_SIZE;
     contextOptions.hint = !options.disableHints;
+    contextOptions.analyzeFunctionBodiesPredicate =
+        _analyzeFunctionBodiesPredicate;
     context.analysisOptions = contextOptions;
 
     // Create and add a ChangeSet
     ChangeSet changeSet = new ChangeSet();
     changeSet.addedSource(source);
     context.applyChanges(changeSet);
   }
 
   /// Fills [errorInfos] using [sources].
   void prepareErrors() {
@@ skipping 57 matching lines @@
       ErrorSeverity status = maxErrorSeverity;
       if (status == ErrorSeverity.WARNING && options.warningsAreFatal) {
         status = ErrorSeverity.ERROR;
       }
       exitCode = status.ordinal;
     }).catchError((ex, st) {
       AnalysisEngine.instance.logger.logError("$ex\n$st");
     });
   }
 
+  bool _analyzeFunctionBodiesPredicate(Source source) {
+    if (source.uri.scheme == 'dart') {
+      return options.showSdkWarnings;
+    }
+    if (source.uri.scheme == 'package') {
+      return options.showPackageWarnings;
+    }
+    return true;

[Brian Wilkerson, 2015/02/27 23:52:05]

This will need to be extended to account for the custom URI map option (sorry
for being vague; I can't remember the command-line flag).

[Paul Berry, 2015/03/02 19:09:45]

Ok, I've added a TODO.

+  }
+
   /// The sync version of analysis.
   ErrorSeverity _analyzeSync(int printMode) {
     // don't try to analyze parts
     if (context.computeKindOf(librarySource) == SourceKind.PART) {
       print("Only libraries can be analyzed.");
       print("$sourcePath is a part and can not be analyzed.");
       return ErrorSeverity.ERROR;
     }
     // resolve library
     var libraryElement = context.computeLibraryElement(librarySource);
@@ skipping 161 matching lines @@
     }
   }
 
   @override
   void logInformation2(String message, Object exception) {
     if (log) {
       stdout.writeln(message);
     }
   }
 }