Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 967323002: Refactor BreakLocationIterator. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor BreakLocationIterator. We now have BreakLocation::Iterator to iterate via RelocIterator, and create a BreakLocation when we are done iterating. The reloc info is stored in BreakLocation in a GC-safe way and instantiated on demand. R=ulan@chromium.org BUG=v8:3924 LOG=N Committed: https://crrev.com/1a608493e55eacf5c7569e2b1213da42eb0e6207 Cr-Commit-Position: refs/heads/master@{#26983}

Patch Set 1 #

Patch Set 2 : fix platform ports #

Patch Set 3 : simplify #

Patch Set 4 : fix test case #

Patch Set 5 : use intptr_t for offset #

Patch Set 6 : static_cast instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+578 lines, -964 lines) Patch
M src/arm/assembler-arm.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
M src/arm/debug-arm.cc View 1 5 chunks +4 lines, -38 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/debug-arm64.cc View 1 2 5 chunks +5 lines, -36 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/assembler.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/debug.h View 1 2 3 4 5 3 chunks +140 lines, -65 lines 0 comments Download
M src/debug.cc View 1 29 chunks +211 lines, -302 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/ia32/debug-ia32.cc View 1 2 1 chunk +37 lines, -36 lines 0 comments Download
M src/mips/assembler-mips.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips/debug-mips.cc View 1 2 4 chunks +4 lines, -38 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/debug-mips64.cc View 1 2 5 chunks +4 lines, -38 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 2 chunks +18 lines, -16 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ppc/assembler-ppc.cc View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/ppc/debug-ppc.cc View 1 2 5 chunks +4 lines, -38 lines 0 comments Download
M src/runtime/runtime-debug.cc View 3 chunks +21 lines, -24 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
M src/x64/debug-x64.cc View 1 2 1 chunk +34 lines, -35 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
M src/x87/debug-x87.cc View 1 2 1 chunk +35 lines, -35 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 3 3 chunks +25 lines, -34 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
5 years, 9 months ago (2015-03-02 15:18:17 UTC) #1
ulan
lgtm
5 years, 9 months ago (2015-03-03 10:22:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967323002/1
5 years, 9 months ago (2015-03-03 10:24:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/3474)
5 years, 9 months ago (2015-03-03 10:28:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967323002/100001
5 years, 9 months ago (2015-03-04 12:44:46 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 9 months ago (2015-03-04 13:15:12 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 13:15:46 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/1a608493e55eacf5c7569e2b1213da42eb0e6207
Cr-Commit-Position: refs/heads/master@{#26983}

Powered by Google App Engine
This is Rietveld 408576698