Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 9673001: Notify RenderWidgets when "tab fullscreen" state changes. (Closed)

Created:
6 years, 10 months ago by bbudge
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Notify RenderWidgets when "tab fullscreen" state changes. BUG=116044 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126513

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M chrome/browser/ui/browser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bbudge
I'd like to add a test. Can you suggest what kind of test would be ...
6 years, 10 months ago (2012-03-09 22:05:42 UTC) #1
darin (slow to review)
LGTM
6 years, 10 months ago (2012-03-09 22:34:30 UTC) #2
darin (slow to review)
On 2012/03/09 22:05:42, bbudge1 wrote: > I'd like to add a test. Can you suggest ...
6 years, 10 months ago (2012-03-09 22:34:56 UTC) #3
bbudge
Adding ben for chrome/browser/ui/browser.cc A change I want to make in RenderWidgetHostImpl is calling FullscreenController::IsFullscreenForTab ...
6 years, 10 months ago (2012-03-12 20:29:58 UTC) #4
Ben Goodger (Google)
lgtm
6 years, 10 months ago (2012-03-12 20:41:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9673001/15001
6 years, 10 months ago (2012-03-12 22:28:34 UTC) #6
commit-bot: I haz the power
Try job failure for 9673001-15001 (retry) on win_rel for steps "installer_util_unittests, check_deps". It's a second ...
6 years, 10 months ago (2012-03-13 01:09:19 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2012-03-13 20:47:19 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698