src/typing.cc - Issue 967243002: Polish Maybe API a bit, removing useless creativity and fixing some signatures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 967243002: Polish Maybe API a bit, removing useless creativity and fixing some signatures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Simplified friendship. Added check in FromJust. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index eddf4c3501e577c9dac14100c46477b853ae6379..1598c09b59b77f23402f418d3fce0d5263df2727 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -655,7 +655,7 @@ void AstTyper::VisitBinaryOperation(BinaryOperation* expr) {

Type* type;

Type* left_type;

Type* right_type;

- Maybe<int> fixed_right_arg;

+ Maybe<int> fixed_right_arg = Nothing<int>();

Handle<AllocationSite> allocation_site;

oracle()->BinaryType(expr->BinaryOperationFeedbackId(),

&left_type, &right_type, &type, &fixed_right_arg,

« include/v8.h ('K') | « src/type-info.cc ('k') | no next file » | no next file with comments »