src/type-info.cc - Issue 967243002: Polish Maybe API a bit, removing useless creativity and fixing some signatures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-info.cc

Issue 967243002: Polish Maybe API a bit, removing useless creativity and fixing some signatures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Simplified friendship. Added check in FromJust. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/type-info.cc

diff --git a/src/type-info.cc b/src/type-info.cc

index 0e23341a445191a97d8f370a57dd4ade7d6e7fbe..51885d5efa82be9b8bc0964c1ef5553c09e6fda0 100644

--- a/src/type-info.cc

+++ b/src/type-info.cc

@@ -279,7 +279,7 @@ void TypeFeedbackOracle::BinaryType(TypeFeedbackId id,

DCHECK(op < BinaryOpICState::FIRST_TOKEN ||

op > BinaryOpICState::LAST_TOKEN);

*left = *right = *result = Type::None(zone());

- *fixed_right_arg = Maybe<int>();

+ *fixed_right_arg = Nothing<int>();

*allocation_site = Handle<AllocationSite>::null();

return;

}

« include/v8.h ('K') | « src/runtime/runtime-object.cc ('k') | src/typing.cc » ('j') | no next file with comments »