src/runtime/runtime-object.cc - Issue 967243002: Polish Maybe API a bit, removing useless creativity and fixing some signatures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-object.cc

Issue 967243002: Polish Maybe API a bit, removing useless creativity and fixing some signatures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Simplified friendship. Added check in FromJust. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-object.cc

diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc

index d05da302728eda7f89112b5feb5fef7efee001b6..1d890f0c03a4173f096f9f221d65f68da3db21cc 100644

--- a/src/runtime/runtime-object.cc

+++ b/src/runtime/runtime-object.cc

@@ -772,7 +772,7 @@ RUNTIME_FUNCTION(Runtime_HasOwnProperty) {

// Fast case: either the key is a real named property or it is not

// an array index and there are no interceptors or hidden

// prototypes.

- Maybe<bool> maybe;

+ Maybe<bool> maybe = Nothing<bool>();

if (key_is_array_index) {

maybe = JSObject::HasOwnElement(js_obj, index);

} else {

« include/v8.h ('K') | « src/objects-inl.h ('k') | src/type-info.cc » ('j') | no next file with comments »