Polish Maybe API a bit, removing useless creativity and fixing some signatures.

Polish Maybe API a bit, removing useless creativity and fixing some signatures.

BUG=v8:3929
LOG=y
R=dcarney@chromium.org

Committed: https://crrev.com/30637108dd3977884cb81741bec248c9eb22f4e3
Cr-Commit-Position: refs/heads/master@{#26936}

[Sven Panne, 2015-03-02 09:10:38]

svenpanne@chromium.org changed reviewers:
+ dcarney@chromium.org

[Sven Panne, 2015-03-02 09:10:38]

Strike while the iron is hot... ;-)

[dcarney, 2015-03-02 10:09:13]

lgtm

[Sven Panne, 2015-03-02 10:20:08]

The CQ bit was checked by svenpanne@chromium.org

[commit-bot: I haz the power, 2015-03-02 10:20:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/967243002/20001

[Sven Panne, 2015-03-02 11:26:44]

The CQ bit was unchecked by svenpanne@chromium.org

[Sven Panne, 2015-03-02 11:27:12]

Committed patchset #2 (id:20001) manually as
30637108dd3977884cb81741bec248c9eb22f4e3 (presubmit successful).

[commit-bot: I haz the power, 2015-03-02 11:27:15]

Patchset 2 (id:??) landed as
https://crrev.com/30637108dd3977884cb81741bec248c9eb22f4e3
Cr-Commit-Position: refs/heads/master@{#26936}

[Nico, 2016-02-26 19:18:25]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-02-26 19:18:26]

https://codereview.chromium.org/967243002/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/967243002/diff/20001/include/v8.h#newcode5737
include/v8.h:5737: V8_INLINE bool IsJust() const { return has_value; }
I saw this since someone made a similar name change in Blink. I think this is a
way worse name than the "uselessly creative" name we had before. People who know
Haskell will get "isJust" but nobody else will without looking it up. "HasValue"
is immediately understandable. Most people don't know Haskell.