api.trigger: refactoring, made extensible

api.trigger: refactoring, made extensible

More an more parameters are being added to trigger_specs that are not
properties. This CL changes api.trigger function to accept trigger specs
instead of properties. A trigger spec may contain properties, as well as
builder_name, buildbot_changes and, in next CL, buildbucket bucket.

Also this change renames "buildbot.changes" to "buildbot_changes",
because a dot cannot be in recipe config schema.

For backward compatibility, if there is "buildername" in a trigger spec,
it is treated in the backward compatible mode.

R=smut@google.com, smut@chromium.org
BUG=449218
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=294290

[nodir, 2015-02-28 01:23:56]

Patchset #1 (id:1) has been deleted

[nodir, 2015-02-28 01:24:02]

PTAL

[nodir, 2015-02-28 01:30:55]

nodir@chromium.org changed reviewers:
+ smut@google.com

[nodir, 2015-02-28 01:32:12]

Patchset #1 (id:20001) has been deleted

[smut, 2015-02-28 01:44:51]

https://codereview.chromium.org/966993002/diff/40001/scripts/common/annotator.py
File scripts/common/annotator.py (right):

https://codereview.chromium.org/966993002/diff/40001/scripts/common/annotator...
scripts/common/annotator.py:455: assert isinstance(changes, list),
'buildbot.changes must be a list'
buildbot.changes -> buildbot_changes

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/trigger/api.py (right):

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/trigger/api.py:50: buildbot.changes (list of dict):
list of Buildbot changes to create.
buildbot.changes -> buildbot_changes

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/trigger/example.py (right):

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/trigger/example.py:44: api.test('buildbot_changes')
+
git add example.expected/buildbot_changes.json

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/trigger/example.py:56:
api.test('backward_compatibility') +
git add example.expected/backward_compatibility.json

[smut, 2015-02-28 01:49:42]

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/trigger/api.py (right):

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/trigger/api.py:30: """Convert from prevoius
"properties-only" mode to trigger spec."""
s/prevouis/previous/

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/trigger/api.py:39: 'properties': props,
The old style might have buildbot.changes in properties. If there is any project
besides downstream iOS using buildbot.changes, you should pull it out into
buildbot_changes as well. If I'm the only one using it, don't bother.

[nodir, 2015-03-02 02:14:05]

Patchset #2 (id:60001) has been deleted

[nodir, 2015-03-02 02:26:11]

Sorry, the firs tpatchset was not really ready. Fixed now

https://codereview.chromium.org/966993002/diff/40001/scripts/common/annotator.py
File scripts/common/annotator.py (right):

https://codereview.chromium.org/966993002/diff/40001/scripts/common/annotator...
scripts/common/annotator.py:455: assert isinstance(changes, list),
'buildbot.changes must be a list'
On 2015/02/28 01:44:51, smut wrote:
> buildbot.changes -> buildbot_changes

Done.

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/trigger/api.py (right):

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/trigger/api.py:30: """Convert from prevoius
"properties-only" mode to trigger spec."""
On 2015/02/28 01:49:42, smut wrote:
> s/prevouis/previous/

Done.

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/trigger/api.py:39: 'properties': props,
On 2015/02/28 01:49:42, smut wrote:
> The old style might have buildbot.changes in properties. If there is any
project
> besides downstream iOS using buildbot.changes, you should pull it out into
> buildbot_changes as well. If I'm the only one using it, don't bother.

I've updated build_internal as well
https://chromereviews.googleplex.com/162917013/

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/trigger/api.py:50: buildbot.changes (list of dict):
list of Buildbot changes to create.
On 2015/02/28 01:44:51, smut wrote:
> buildbot.changes -> buildbot_changes

Done.

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/trigger/example.py (right):

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/trigger/example.py:44: api.test('buildbot_changes')
+
On 2015/02/28 01:44:51, smut wrote:
> git add example.expected/buildbot_changes.json

Done.

https://codereview.chromium.org/966993002/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/trigger/example.py:56:
api.test('backward_compatibility') +
On 2015/02/28 01:44:51, smut wrote:
> git add example.expected/backward_compatibility.json

Done.

[nodir, 2015-03-02 02:33:49]

Patchset #2 (id:80001) has been deleted

[smut, 2015-03-03 00:39:32]

lgtm

[nodir, 2015-03-03 01:02:39]

Committed patchset #2 (id:100001) manually as 294290.