api.trigger: refactoring, made extensible

scripts/slave/recipe_modules/trigger/example.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 DEPS = [
     'properties',
     'trigger'
 ]
 
 
 def GenSteps(api):
 
   def normalize_properties(props):
     props = dict(props)
     if 'buildbot.changes' in props:
       props['buildbot.changes'] = list(props['buildbot.changes'])
     return props
 
   prop_list = map(normalize_properties, api.properties['trigger_props_list'])
   api.trigger(*prop_list)
 
 
 def GenTests(api):
   yield (
       api.test('trigger_one_build') +
       api.properties(trigger_props_list=[{
-          'buildername': 'cross-compiler',
-          'a': 1,
+          'builder_name': 'cross-compiler',
+          'properties': {'a': 1},
         }])
       )
 
   yield (
       api.test('trigger_two_builds') +
       api.properties(trigger_props_list=[{
-          'buildername': 'cross-compiler',
-          'a': 1,
+          'builder_name': 'cross-compiler',
+          'properties': {'a': 1},
         }, {
-          'buildername': 'cross-compiler',
-          'a': 2,
+          'builder_name': 'cross-compiler',
+          'properties': {'a': 2},
         }])
       )
 
   yield (
-      api.test('buildbot.changes') +
+      api.test('buildbot_changes') +

[smut, 2015/02/28 01:44:51]

git add example.expected/buildbot_changes.json

[nodir, 2015/03/02 02:26:11]

Done.

       api.properties(trigger_props_list=[{
-          'buildername': 'cross-compiler',
-          'buildbot.changes': [{
+          'builder_name': 'cross-compiler',
+          'buildbot_changes': [{
               'author': 'someone@chromium.org',
               'revision': 'deadbeef',
               'comments': 'hello world!',
           }],
         }])
       )
+
+  yield (
+      api.test('backward_compatibility') +

[smut, 2015/02/28 01:44:51]

git add example.expected/backward_compatibility.json

[nodir, 2015/03/02 02:26:11]

Done.

+      api.properties(trigger_props_list=[{
+          'buildername': 'cross-compiler',
+          'a': 1,
+        }])
+      )