chrome/browser/ui/views/download/download_item_view.cc - Issue 966983002: downloads: clicking "remove" on chrome://downloads should also hide shelf item.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_item_view.cc

Issue 966983002: downloads: clicking "remove" on chrome://downloads should also hide shelf item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: probably more like this Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_ui_controller.h ('K') | « chrome/browser/ui/cocoa/download/download_item_mac.mm ('k') | chrome/browser/ui/views/download/download_shelf_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/download/download_item_view.cc

diff --git a/chrome/browser/ui/views/download/download_item_view.cc b/chrome/browser/ui/views/download/download_item_view.cc

index 457e4d49fbb2460b9727e8242cc5b46e2da3f8c3..36db539e4dec0c22c5c292bea2bc080a5d1069a4 100644

--- a/chrome/browser/ui/views/download/download_item_view.cc

+++ b/chrome/browser/ui/views/download/download_item_view.cc

@@ -282,6 +282,9 @@ void DownloadItemView::OnDownloadUpdated(DownloadItem* download_item) {

// Force the shelf to layout again as our size has changed.

shelf_->Layout();

SchedulePaint();

+ } else if (!model_.ShouldShowInShelf()) {

+ shelf_->RemoveDownloadView(this);

+ return;

} else {

base::string16 status_text = model_.GetStatusText();

switch (download()->GetState()) {