chrome/browser/ui/cocoa/download/download_item_mac.mm - Issue 966983002: downloads: clicking "remove" on chrome://downloads should also hide shelf item.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_item_mac.mm

Issue 966983002: downloads: clicking "remove" on chrome://downloads should also hide shelf item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: probably more like this Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_ui_controller.h ('K') | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/views/download/download_item_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/download/download_item_mac.mm

diff --git a/chrome/browser/ui/cocoa/download/download_item_mac.mm b/chrome/browser/ui/cocoa/download/download_item_mac.mm

index bf1ebc91e9e431fd4994cc5b5807438dd212131b..9ad3bfd57c0d69707523a2d00273687f9c186302 100644

--- a/chrome/browser/ui/cocoa/download/download_item_mac.mm

+++ b/chrome/browser/ui/cocoa/download/download_item_mac.mm

@@ -42,6 +42,11 @@ void DownloadItemMac::OnDownloadUpdated(content::DownloadItem* download) {

[item_controller_ updateToolTip];

}

+ if (!download_model_.ShouldShowInShelf()) {

+ [item_controller_ remove]; // We're deleted now!

+ return;

+ }

switch (download->GetState()) {

case DownloadItem::COMPLETE:

if (download_model_.ShouldRemoveFromShelfWhenComplete()) {

« chrome/browser/download/download_ui_controller.h ('K') | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/views/download/download_item_view.cc » ('j') | no next file with comments »