Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 966923003: Make SVGLengthMode an enum class (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-rendering, Dominik Röttsches, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, Eric Willigers, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, Mike Lawther (Google), pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, Steve Block, Timothy Loh, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make SVGLengthMode an enum class Mostly search and replace; A minor tweak in LinearGradientAttributes changing to 'Height' for m_y1 and m_y2. Dropping the default value for "detached" SVGLength objects. BUG=461375 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -134 lines) Patch
M Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGRect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/svg/SVGPathData.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/LinearGradientAttributes.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/PatternAttributes.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/RadialGradientAttributes.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGCircleElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGLength.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLength.cpp View 2 chunks +26 lines, -25 lines 0 comments Download
M Source/core/svg/SVGLengthContext.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLengthList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLineElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGRectElement.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pdr.
Much type safety. Here on Chromium, Safety is our number one goal. We have gone ...
5 years, 9 months ago (2015-03-03 18:03:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966923003/1
5 years, 9 months ago (2015-03-04 09:06:44 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 12:08:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191274

Powered by Google App Engine
This is Rietveld 408576698