Source/web/ExternalPopupMenuTest.cpp - Issue 966883002: renderer/RenderMenuList.* -> layout/LayoutMenuList.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ExternalPopupMenuTest.cpp

Issue 966883002: renderer/RenderMenuList.* -> layout/LayoutMenuList.* (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove OWNERS, allowing Source/core/rendering to be deleted. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ExternalPopupMenuTest.cpp

diff --git a/Source/web/ExternalPopupMenuTest.cpp b/Source/web/ExternalPopupMenuTest.cpp

index cb36e4c530fafece72d132042d27565fa12c4086..cf52eef11a6b360598e9f6752a741f9b0a01f74c 100644

--- a/Source/web/ExternalPopupMenuTest.cpp

+++ b/Source/web/ExternalPopupMenuTest.cpp

@@ -10,8 +10,8 @@

#include "core/frame/PinchViewport.h"

#include "core/html/HTMLSelectElement.h"

#include "core/html/forms/PopupMenuClient.h"

+#include "core/layout/LayoutMenuList.h"

#include "core/page/Page.h"

-#include "core/rendering/RenderMenuList.h"

#include "core/testing/DummyPageHolder.h"

#include "core/testing/URLTestHelpers.h"

#include "platform/PopupMenu.h"

@@ -196,7 +196,7 @@ TEST_F(ExternalPopupMenuTest, PopupAccountsForPinchViewportOffset)

webView()->layout();

HTMLSelectElement* select = toHTMLSelectElement(mainFrame()->frame()->document()->getElementById("select"));

- RenderMenuList* menuList = toRenderMenuList(select->renderer());

+ LayoutMenuList* menuList = toLayoutMenuList(select->renderer());

ASSERT_TRUE(menuList);

PinchViewport& pinchViewport = webView()->page()->frameHost().pinchViewport();

@@ -219,7 +219,7 @@ TEST_F(ExternalPopupMenuTest, DidAcceptIndex)

loadFrame("select.html");

HTMLSelectElement* select = toHTMLSelectElement(mainFrame()->frame()->document()->getElementById("select"));

- RenderMenuList* menuList = toRenderMenuList(select->renderer());

+ LayoutMenuList* menuList = toLayoutMenuList(select->renderer());

ASSERT_TRUE(menuList);

menuList->showPopup();

@@ -238,7 +238,7 @@ TEST_F(ExternalPopupMenuTest, DidAcceptIndices)

loadFrame("select.html");

HTMLSelectElement* select = toHTMLSelectElement(mainFrame()->frame()->document()->getElementById("select"));

- RenderMenuList* menuList = toRenderMenuList(select->renderer());

+ LayoutMenuList* menuList = toLayoutMenuList(select->renderer());

ASSERT_TRUE(menuList);

menuList->showPopup();

@@ -259,7 +259,7 @@ TEST_F(ExternalPopupMenuTest, DidAcceptIndicesClearSelect)

loadFrame("select.html");

HTMLSelectElement* select = toHTMLSelectElement(mainFrame()->frame()->document()->getElementById("select"));

- RenderMenuList* menuList = toRenderMenuList(select->renderer());

+ LayoutMenuList* menuList = toLayoutMenuList(select->renderer());

ASSERT_TRUE(menuList);

menuList->showPopup();

« no previous file with comments | « Source/modules/accessibility/AXObjectCacheImpl.cpp ('k') | Source/web/PopupContainer.cpp » ('j') | no next file with comments »