Source/web/PopupContainer.cpp - Issue 966883002: renderer/RenderMenuList.* -> layout/LayoutMenuList.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupContainer.cpp

Issue 966883002: renderer/RenderMenuList.* -> layout/LayoutMenuList.* (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove OWNERS, allowing Source/core/rendering to be deleted. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/PopupContainer.cpp

diff --git a/Source/web/PopupContainer.cpp b/Source/web/PopupContainer.cpp

index 9eeaad85c06cfef1ed9a050d9710b2ee334b7c36..e337b2a94b3424d7d7240f0b32852e04e9b3282d 100644

--- a/Source/web/PopupContainer.cpp

+++ b/Source/web/PopupContainer.cpp

@@ -262,7 +262,7 @@ void PopupContainer::notifyPopupHidden()

// torn down -- the connection to the FrameHost has been snipped &

// there's no page. Hence the null check.

- // In a non-Oilpan setting, the RenderMenuList that controls/owns

+ // In a non-Oilpan setting, the LayoutMenuList that controls/owns

// the PopupMenuChromium object and this PopupContainer is torn

// down and destructed before the frame and frame owner, hence the

// page will always be available in that setting and this will

« no previous file with comments | « Source/web/ExternalPopupMenuTest.cpp ('k') | Source/web/PopupMenuTest.cpp » ('j') | no next file with comments »