Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: Source/core/dom/DOMStringList.idl

Issue 966843002: Mark DOMStringList.contains() as deprecated, add console warning. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Deprecate named getter Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/DOMStringList.idl
diff --git a/Source/core/dom/DOMStringList.idl b/Source/core/dom/DOMStringList.idl
index ca27f1d5ac3838aa8540314185c5e39ab688922c..1bd16c9f915389c693385004ae20250c135644cd 100644
--- a/Source/core/dom/DOMStringList.idl
+++ b/Source/core/dom/DOMStringList.idl
@@ -30,6 +30,8 @@
WillBeGarbageCollected,
] interface DOMStringList {
readonly attribute unsigned long length;
- getter DOMString? item(unsigned long index);
- [MeasureAs=DOMStringListContains] boolean contains(DOMString string);
+ [DeprecateAs=DOMStringListItem] DOMString? item(unsigned long index);
+ getter DOMString? (unsigned long index);
+ // FIXME: If Array.prototype.includes is added, add includes() and update deprecation message.
philipj_slow 2015/03/06 03:03:49 I don't think it's a given that we'll want to add
jsbell 2015/03/06 17:19:20 Done.
+ [DeprecateAs=DOMStringListContains] boolean contains(DOMString string);
};

Powered by Google App Engine
This is Rietveld 408576698