Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: Source/core/dom/DOMStringList.idl

Issue 966843002: Mark DOMStringList.contains() as deprecated, add console warning. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Deprecate named getter Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 12 matching lines...) Expand all
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 // https://dom.spec.whatwg.org/#domstringlist 26 // https://dom.spec.whatwg.org/#domstringlist
27 27
28 // FIXME: DOMStringList has been removed from the spec. crbug.com/460726 28 // FIXME: DOMStringList has been removed from the spec. crbug.com/460726
29 [ 29 [
30 WillBeGarbageCollected, 30 WillBeGarbageCollected,
31 ] interface DOMStringList { 31 ] interface DOMStringList {
32 readonly attribute unsigned long length; 32 readonly attribute unsigned long length;
33 getter DOMString? item(unsigned long index); 33 [DeprecateAs=DOMStringListItem] DOMString? item(unsigned long index);
34 [MeasureAs=DOMStringListContains] boolean contains(DOMString string); 34 getter DOMString? (unsigned long index);
35 // FIXME: If Array.prototype.includes is added, add includes() and update de precation message.
philipj_slow 2015/03/06 03:03:49 I don't think it's a given that we'll want to add
jsbell 2015/03/06 17:19:20 Done.
36 [DeprecateAs=DOMStringListContains] boolean contains(DOMString string);
35 }; 37 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698