Issue 966753002: Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType

Issue 966753002: Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (Closed)

Created:
5 years, 9 months ago by scroggo

Modified:
5 years, 9 months ago

Reviewers:
reed2, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (patchset #3 id:40001 of https://codereview.chromium.org/964613002/) Reason for revert: This breaks Android framework build. See https://android-build.storage.googleapis.com/builds/git_master-skia-linux-volantisg-userdebug/1759130/7f0fcdbf3c0d47530d770a15c912298dac20dd7d90a01de63ecb9ba16c96b25c/logs/build_error.log?Expires=1425047630&GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com&Signature=BHPS1lffyH7WykwyEw5RXVVXWqQK5rab%2B6Pl1VaUrTlmWT%2FXb6fq%2FBe22AUDZYFPG24MBR%2F2IzIDzTqH3mihQS9wIkcKJ4kJpA2G%2BI3l8jCX20brZSr3bsDSx%2F4wsLwU1bBpIxI%2FbrauoPRqddbXP8sNI1l51u6ZCxpvRQms9Mc%3D We need to stop them from using kIgnore before we can reland this. Original issue's description: > replace kIgnore_SkAlphaType with kUnknown_SkAlphaType > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/1c8aeeaebce9675197be31bd769e8ffa2531bf86 TBR=reed@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/574290f61a47bd1ce1f9e2d941533bda9c8f03fe

Patch Set 1 #

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -16 lines)			Patch
M	include/core/SkCanvas.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkImageInfo.h	View	4 chunks	+13 lines, -4 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkBitmapDevice.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkConfig8888.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkImageInfo.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/utils/mac/SkCreateCGImageRef.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scroggo

Created Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType

5 years, 9 months ago (2015-02-27 14:21:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966753002/1

5 years, 9 months ago (2015-02-27 14:21:51 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/574290f61a47bd1ce1f9e2d941533bda9c8f03fe

5 years, 9 months ago (2015-02-27 14:22:03 UTC) #3

reed1

5 years, 9 months ago (2015-02-27 18:22:27 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/966853002/ by reed@google.com.

The reason for reverting is: Android has been updated, so we can re-land this..

Expand Messages | Collapse Messages