Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: src/core/SkImageInfo.cpp

Issue 966753002: Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkConfig8888.cpp ('k') | src/utils/mac/SkCreateCGImageRef.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2010 Google Inc. 2 * Copyright 2010 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkImageInfo.h" 8 #include "SkImageInfo.h"
9 #include "SkReadBuffer.h" 9 #include "SkReadBuffer.h"
10 #include "SkWriteBuffer.h" 10 #include "SkWriteBuffer.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 SkASSERT(0 == (fAlphaType & ~0xFF)); 43 SkASSERT(0 == (fAlphaType & ~0xFF));
44 SkASSERT(0 == (fColorType & ~0xFF)); 44 SkASSERT(0 == (fColorType & ~0xFF));
45 uint32_t packed = (fProfileType << 16) | (fAlphaType << 8) | fColorType; 45 uint32_t packed = (fProfileType << 16) | (fAlphaType << 8) | fColorType;
46 buffer.write32(packed); 46 buffer.write32(packed);
47 } 47 }
48 48
49 bool SkColorTypeValidateAlphaType(SkColorType colorType, SkAlphaType alphaType, 49 bool SkColorTypeValidateAlphaType(SkColorType colorType, SkAlphaType alphaType,
50 SkAlphaType* canonical) { 50 SkAlphaType* canonical) {
51 switch (colorType) { 51 switch (colorType) {
52 case kUnknown_SkColorType: 52 case kUnknown_SkColorType:
53 alphaType = kUnknown_SkAlphaType; 53 alphaType = kIgnore_SkAlphaType;
54 break; 54 break;
55 case kAlpha_8_SkColorType: 55 case kAlpha_8_SkColorType:
56 if (kUnpremul_SkAlphaType == alphaType) { 56 if (kUnpremul_SkAlphaType == alphaType) {
57 alphaType = kPremul_SkAlphaType; 57 alphaType = kPremul_SkAlphaType;
58 } 58 }
59 // fall-through 59 // fall-through
60 case kIndex_8_SkColorType: 60 case kIndex_8_SkColorType:
61 case kARGB_4444_SkColorType: 61 case kARGB_4444_SkColorType:
62 case kRGBA_8888_SkColorType: 62 case kRGBA_8888_SkColorType:
63 case kBGRA_8888_SkColorType: 63 case kBGRA_8888_SkColorType:
64 if (kUnknown_SkAlphaType == alphaType) { 64 if (kIgnore_SkAlphaType == alphaType) {
65 return false; 65 return false;
66 } 66 }
67 break; 67 break;
68 case kRGB_565_SkColorType: 68 case kRGB_565_SkColorType:
69 alphaType = kOpaque_SkAlphaType; 69 alphaType = kOpaque_SkAlphaType;
70 break; 70 break;
71 default: 71 default:
72 return false; 72 return false;
73 } 73 }
74 if (canonical) { 74 if (canonical) {
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 // here x,y are either 0 or negative 113 // here x,y are either 0 or negative
114 fPixels = ((char*)fPixels - y * fRowBytes - x * fInfo.bytesPerPixel()); 114 fPixels = ((char*)fPixels - y * fRowBytes - x * fInfo.bytesPerPixel());
115 // the intersect may have shrunk info's logical size 115 // the intersect may have shrunk info's logical size
116 fInfo = fInfo.makeWH(srcR.width(), srcR.height()); 116 fInfo = fInfo.makeWH(srcR.width(), srcR.height());
117 fX = srcR.x(); 117 fX = srcR.x();
118 fY = srcR.y(); 118 fY = srcR.y();
119 119
120 return true; 120 return true;
121 } 121 }
122 122
OLDNEW
« no previous file with comments | « src/core/SkConfig8888.cpp ('k') | src/utils/mac/SkCreateCGImageRef.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698