Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: remoting/protocol/network_settings_unittest.cc

Issue 966433002: Malformed PortRange or ThirdPartyAuthConfig trigger OnPolicyError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing a Windows-specific, pre-processor-related build break. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/network_settings.cc ('k') | remoting/protocol/port_range.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/network_settings_unittest.cc
diff --git a/remoting/protocol/network_settings_unittest.cc b/remoting/protocol/network_settings_unittest.cc
deleted file mode 100644
index 398d5593909a631a3a7dc801c21d367389d4ab68..0000000000000000000000000000000000000000
--- a/remoting/protocol/network_settings_unittest.cc
+++ /dev/null
@@ -1,44 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "remoting/protocol/network_settings.h"
-
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace remoting {
-namespace protocol {
-
-TEST(ParsePortRange, Basic) {
- uint16 min, max;
-
- // Valid range
- EXPECT_TRUE(NetworkSettings::ParsePortRange("1-65535", &min, &max));
- EXPECT_EQ(1u, min);
- EXPECT_EQ(65535u, max);
-
- EXPECT_TRUE(NetworkSettings::ParsePortRange(" 1 - 65535 ", &min, &max));
- EXPECT_EQ(1u, min);
- EXPECT_EQ(65535u, max);
-
- EXPECT_TRUE(NetworkSettings::ParsePortRange("12400-12400", &min, &max));
- EXPECT_EQ(12400u, min);
- EXPECT_EQ(12400u, max);
-
- // Invalid
- EXPECT_FALSE(NetworkSettings::ParsePortRange("", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("-65535", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("1-", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("-", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("-1-65535", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("1--65535", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("1-65535-", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("0-65535", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("1-65536", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("1-4294967295", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("10-1", &min, &max));
- EXPECT_FALSE(NetworkSettings::ParsePortRange("1foo-2bar", &min, &max));
-}
-
-} // namespace protocol
-} // namespace remoting
« no previous file with comments | « remoting/protocol/network_settings.cc ('k') | remoting/protocol/port_range.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698