Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2622)

Unified Diff: remoting/protocol/network_settings.cc

Issue 966433002: Malformed PortRange or ThirdPartyAuthConfig trigger OnPolicyError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing a Windows-specific, pre-processor-related build break. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/network_settings.h ('k') | remoting/protocol/network_settings_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/network_settings.cc
diff --git a/remoting/protocol/network_settings.cc b/remoting/protocol/network_settings.cc
deleted file mode 100644
index 65068ef951197ce2f76e28c896025f23f6200a0e..0000000000000000000000000000000000000000
--- a/remoting/protocol/network_settings.cc
+++ /dev/null
@@ -1,47 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "remoting/protocol/network_settings.h"
-
-#include <limits.h>
-#include <stdlib.h>
-
-#include "base/strings/string_number_conversions.h"
-#include "base/strings/string_util.h"
-
-namespace remoting {
-namespace protocol {
-
-// static
- bool NetworkSettings::ParsePortRange(const std::string& port_range,
- uint16* out_min_port,
- uint16* out_max_port) {
- size_t separator_index = port_range.find('-');
- if (separator_index == std::string::npos)
- return false;
-
- std::string min_port_string, max_port_string;
- base::TrimWhitespaceASCII(port_range.substr(0, separator_index),
- base::TRIM_ALL,
- &min_port_string);
- base::TrimWhitespaceASCII(port_range.substr(separator_index + 1),
- base::TRIM_ALL,
- &max_port_string);
-
- unsigned min_port, max_port;
- if (!base::StringToUint(min_port_string, &min_port) ||
- !base::StringToUint(max_port_string, &max_port)) {
- return false;
- }
-
- if (min_port == 0 || min_port > max_port || max_port > USHRT_MAX)
- return false;
-
- *out_min_port = static_cast<uint16>(min_port);
- *out_max_port = static_cast<uint16>(max_port);
- return true;
-}
-
-} // namespace protocol
-} // namespace remoting
« no previous file with comments | « remoting/protocol/network_settings.h ('k') | remoting/protocol/network_settings_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698