Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 9664045: [File Manager] Use content url for playing media files from a gdata directory (Closed)

Created:
8 years, 9 months ago by Vladislav Kaznacheev
Modified:
8 years, 9 months ago
Reviewers:
dgozman, SeRya
CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[File Manager] Use content url for playing media files from a gdata directory BUG=chromium-os:27450 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126080

Patch Set 1 #

Patch Set 2 : Permissions #

Total comments: 4

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -114 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 2 chunks +8 lines, -37 lines 0 comments Download
M chrome/browser/resources/file_manager/js/image_editor/image_view.js View 1 2 3 chunks +26 lines, -25 lines 0 comments Download
M chrome/browser/resources/file_manager/js/media/audio_player.js View 4 chunks +35 lines, -22 lines 0 comments Download
M chrome/browser/resources/file_manager/js/metadata/metadata_provider.js View 7 chunks +107 lines, -29 lines 0 comments Download
M chrome/browser/resources/file_manager/manifest.json View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Vladislav Kaznacheev
Please review.
8 years, 9 months ago (2012-03-11 11:03:25 UTC) #1
dgozman
https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js File chrome/browser/resources/file_manager/js/image_editor/image_view.js (right): https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js#newcode224 chrome/browser/resources/file_manager/js/image_editor/image_view.js:224: source = metadata.contentURL; Where is |source| defined and used? ...
8 years, 9 months ago (2012-03-11 13:17:41 UTC) #2
Vladislav Kaznacheev
PTAL https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js File chrome/browser/resources/file_manager/js/image_editor/image_view.js (right): https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js#newcode224 chrome/browser/resources/file_manager/js/image_editor/image_view.js:224: source = metadata.contentURL; This is a parameter, and ...
8 years, 9 months ago (2012-03-11 14:09:53 UTC) #3
dgozman
LGTM
8 years, 9 months ago (2012-03-11 14:28:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/9664045/4006
8 years, 9 months ago (2012-03-11 19:41:45 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-11 20:59:04 UTC) #6
Change committed as 126080

Powered by Google App Engine
This is Rietveld 408576698