Chromium Code Reviews
Help | Chromium Project | Sign in
(200)

Issue 9664045: [File Manager] Use content url for playing media files from a gdata directory (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Vladislav Kaznacheev
Modified:
3 years, 4 months ago
Reviewers:
dgozman, SeRya
CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[File Manager] Use content url for playing media files from a gdata directory BUG=chromium-os:27450 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126080

Patch Set 1 #

Patch Set 2 : Permissions #

Total comments: 4

Patch Set 3 : Addressed comments #

Messages

Total messages: 6 (0 generated)
Vladislav Kaznacheev
Please review.
3 years, 4 months ago (2012-03-11 11:03:25 UTC) #1
dgozman
https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js File chrome/browser/resources/file_manager/js/image_editor/image_view.js (right): https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js#newcode224 chrome/browser/resources/file_manager/js/image_editor/image_view.js:224: source = metadata.contentURL; Where is |source| defined and used? ...
3 years, 4 months ago (2012-03-11 13:17:41 UTC) #2
Vladislav Kaznacheev
PTAL https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js File chrome/browser/resources/file_manager/js/image_editor/image_view.js (right): https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js#newcode224 chrome/browser/resources/file_manager/js/image_editor/image_view.js:224: source = metadata.contentURL; This is a parameter, and ...
3 years, 4 months ago (2012-03-11 14:09:53 UTC) #3
dgozman
LGTM
3 years, 4 months ago (2012-03-11 14:28:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/9664045/4006
3 years, 4 months ago (2012-03-11 19:41:45 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2012-03-11 20:59:04 UTC) #6
Change committed as 126080
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5