Chromium Code Reviews
Help | Chromium Project | Sign in
(56)

Issue 9664045: [File Manager] Use content url for playing media files from a gdata directory (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Vladislav Kaznacheev
Modified:
2 years, 1 month ago
Reviewers:
dgozman, SeRya
CC:
chromium-reviews_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv
Visibility:
Public.

Description

[File Manager] Use content url for playing media files from a gdata directory


BUG=chromium-os:27450
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126080

Patch Set 1 #

Patch Set 2 : Permissions #

Total comments: 4

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -114 lines) Lint Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 2 chunks +8 lines, -37 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/js/image_editor/image_view.js View 1 2 3 chunks +26 lines, -25 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/js/media/audio_player.js View 4 chunks +35 lines, -22 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/js/metadata/metadata_provider.js View 7 chunks +107 lines, -29 lines 0 comments ? errors Download
M chrome/browser/resources/file_manager/manifest.json View 1 1 chunk +2 lines, -1 line 0 comments ? errors Download
Commit:

Messages

Total messages: 6
Vladislav Kaznacheev
Please review.
2 years, 1 month ago #1
dgozman
https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js File chrome/browser/resources/file_manager/js/image_editor/image_view.js (right): https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js#newcode224 chrome/browser/resources/file_manager/js/image_editor/image_view.js:224: source = metadata.contentURL; Where is |source| defined and used? ...
2 years, 1 month ago #2
Vladislav Kaznacheev
PTAL https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js File chrome/browser/resources/file_manager/js/image_editor/image_view.js (right): https://chromiumcodereview.appspot.com/9664045/diff/3001/chrome/browser/resources/file_manager/js/image_editor/image_view.js#newcode224 chrome/browser/resources/file_manager/js/image_editor/image_view.js:224: source = metadata.contentURL; This is a parameter, and ...
2 years, 1 month ago #3
dgozman
LGTM
2 years, 1 month ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/9664045/4006
2 years, 1 month ago #5
I haz the power (commit-bot)
2 years, 1 month ago #6
Change committed as 126080
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6