Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1573)

Issue 966063003: Overhaul the semantics of Request.handlerPath and Request.url. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/shelf@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Overhaul the semantics of Request.handlerPath and Request.url. The new semantics are easier to understand and make it easier to write handlers. For full details, see the changelog. Request.handlerPath used to be named Request.scriptName; the new name reflects its semantics much better. R=kevmoo@google.com Committed: https://github.com/dart-lang/shelf/commit/287d1485534b52a25c4405af53cf9a87f2785f97

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge #

Patch Set 3 : Fix constructor signature. #

Total comments: 1

Patch Set 4 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -218 lines) Patch
M CHANGELOG.md View 1 1 chunk +26 lines, -1 line 0 comments Download
M README.md View 1 2 chunks +22 lines, -1 line 0 comments Download
M lib/src/handlers/logger.dart View 1 2 3 4 chunks +11 lines, -9 lines 0 comments Download
M lib/src/request.dart View 1 2 3 6 chunks +122 lines, -97 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/log_middleware_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/request_test.dart View 1 4 chunks +157 lines, -105 lines 0 comments Download
M test/shelf_io_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/test_util.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
nweiz
5 years, 5 months ago (2015-03-04 21:28:07 UTC) #1
kevmoo
On 2015/03/04 21:28:07, nweiz wrote: Have you rebased on the latest master? It looks like ...
5 years, 5 months ago (2015-03-04 21:45:19 UTC) #2
nweiz
On 2015/03/04 21:45:19, kevmoo wrote: > On 2015/03/04 21:28:07, nweiz wrote: > > Have you ...
5 years, 5 months ago (2015-03-04 21:58:05 UTC) #3
kevmoo
LGTM - see long line and check to see why log_middleware_test.dart is failing with this ...
5 years, 5 months ago (2015-03-04 22:29:35 UTC) #4
nweiz
Code review changes
5 years, 5 months ago (2015-03-04 23:46:31 UTC) #5
nweiz
https://codereview.chromium.org/966063003/diff/1/lib/src/request.dart File lib/src/request.dart (right): https://codereview.chromium.org/966063003/diff/1/lib/src/request.dart#newcode50 lib/src/request.dart:50: /// [handlerPath] is always a root-relative URL path; that ...
5 years, 5 months ago (2015-03-04 23:46:53 UTC) #6
nweiz
5 years, 5 months ago (2015-03-04 23:47:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
287d1485534b52a25c4405af53cf9a87f2785f97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698