Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: lib/src/handlers/logger.dart

Issue 966063003: Overhaul the semantics of Request.handlerPath and Request.url. (Closed) Base URL: git@github.com:dart-lang/shelf@master
Patch Set: Code review changes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « README.md ('k') | lib/src/request.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/handlers/logger.dart
diff --git a/lib/src/handlers/logger.dart b/lib/src/handlers/logger.dart
index f0833d701b66ca4e04e5d0b9d2bf8fffc835631e..eaac75c70465d22ab7907171a12035adb00879e4 100644
--- a/lib/src/handlers/logger.dart
+++ b/lib/src/handlers/logger.dart
@@ -31,8 +31,8 @@ Middleware logRequests({void logger(String msg, bool isError)}) =>
var watch = new Stopwatch()..start();
return syncFuture(() => innerHandler(request)).then((response) {
- var msg = _getMessage(startTime, response.statusCode, request.url,
- request.method, watch.elapsed);
+ var msg = _getMessage(startTime, response.statusCode,
+ request.requestedUri, request.method, watch.elapsed);
logger(msg, false);
@@ -40,8 +40,8 @@ Middleware logRequests({void logger(String msg, bool isError)}) =>
}, onError: (error, stackTrace) {
if (error is HijackException) throw error;
- var msg = _getErrorMessage(startTime, request.url, request.method,
- watch.elapsed, error, stackTrace);
+ var msg = _getErrorMessage(startTime, request.requestedUri,
+ request.method, watch.elapsed, error, stackTrace);
logger(msg, true);
@@ -50,12 +50,13 @@ Middleware logRequests({void logger(String msg, bool isError)}) =>
};
};
-String _getMessage(DateTime requestTime, int statusCode, Uri url, String method,
- Duration elapsedTime) {
- return '${requestTime}\t$elapsedTime\t$method\t[${statusCode}]\t${url}';
+String _getMessage(DateTime requestTime, int statusCode, Uri requestedUri,
+ String method, Duration elapsedTime) {
+ return '${requestTime}\t$elapsedTime\t$method\t[${statusCode}]\t'
+ '${requestedUri.path}${requestedUri.query}';
}
-String _getErrorMessage(DateTime requestTime, Uri url, String method,
+String _getErrorMessage(DateTime requestTime, Uri requestedUri, String method,
Duration elapsedTime, Object error, StackTrace stack) {
var chain = new Chain.current();
if (stack != null) {
@@ -63,7 +64,8 @@ String _getErrorMessage(DateTime requestTime, Uri url, String method,
.foldFrames((frame) => frame.isCore || frame.package == 'shelf').terse;
}
- var msg = '${requestTime}\t$elapsedTime\t$method\t${url}\n$error';
+ var msg = '${requestTime}\t$elapsedTime\t$method\t${requestedUri.path}'
+ '${requestedUri.query}\n$error';
if (chain == null) return msg;
return '$msg\n$chain';
« no previous file with comments | « README.md ('k') | lib/src/request.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698