src/mips/full-codegen-mips.cc - Issue 96593005: MIPS: Fix --new-string-add feature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/full-codegen-mips.cc

Issue 96593005: MIPS: Fix --new-string-add feature. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/full-codegen-mips.cc

diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc

index 0407f01c084e1b742173c7d6d397d1c9d73b4b58..35fbad06e4453b78b4ed1faa9b1ab38ed15a42e1 100644

--- a/src/mips/full-codegen-mips.cc

+++ b/src/mips/full-codegen-mips.cc

@@ -3734,6 +3734,7 @@ void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {

VisitForAccumulatorValue(args->at(1));

__ pop(a1);

+ __ mov(a0, result_register()); // NewStringAddStub requires args in a0, a1.

NewStringAddStub stub(STRING_ADD_CHECK_BOTH, NOT_TENURED);

__ CallStub(&stub);

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »