Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 96593005: MIPS: Fix --new-string-add feature. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3716 matching lines...) Expand 10 before | Expand all | Expand 10 after
3727 3727
3728 3728
3729 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 3729 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
3730 ZoneList<Expression*>* args = expr->arguments(); 3730 ZoneList<Expression*>* args = expr->arguments();
3731 ASSERT_EQ(2, args->length()); 3731 ASSERT_EQ(2, args->length());
3732 if (FLAG_new_string_add) { 3732 if (FLAG_new_string_add) {
3733 VisitForStackValue(args->at(0)); 3733 VisitForStackValue(args->at(0));
3734 VisitForAccumulatorValue(args->at(1)); 3734 VisitForAccumulatorValue(args->at(1));
3735 3735
3736 __ pop(a1); 3736 __ pop(a1);
3737 __ mov(a0, result_register()); // NewStringAddStub requires args in a0, a1.
3737 NewStringAddStub stub(STRING_ADD_CHECK_BOTH, NOT_TENURED); 3738 NewStringAddStub stub(STRING_ADD_CHECK_BOTH, NOT_TENURED);
3738 __ CallStub(&stub); 3739 __ CallStub(&stub);
3739 } else { 3740 } else {
3740 VisitForStackValue(args->at(0)); 3741 VisitForStackValue(args->at(0));
3741 VisitForStackValue(args->at(1)); 3742 VisitForStackValue(args->at(1));
3742 3743
3743 StringAddStub stub(STRING_ADD_CHECK_BOTH); 3744 StringAddStub stub(STRING_ADD_CHECK_BOTH);
3744 __ CallStub(&stub); 3745 __ CallStub(&stub);
3745 } 3746 }
3746 context()->Plug(v0); 3747 context()->Plug(v0);
(...skipping 1228 matching lines...) Expand 10 before | Expand all | Expand 10 after
4975 Assembler::target_address_at(pc_immediate_load_address)) == 4976 Assembler::target_address_at(pc_immediate_load_address)) ==
4976 reinterpret_cast<uint32_t>( 4977 reinterpret_cast<uint32_t>(
4977 isolate->builtins()->OsrAfterStackCheck()->entry())); 4978 isolate->builtins()->OsrAfterStackCheck()->entry()));
4978 return OSR_AFTER_STACK_CHECK; 4979 return OSR_AFTER_STACK_CHECK;
4979 } 4980 }
4980 4981
4981 4982
4982 } } // namespace v8::internal 4983 } } // namespace v8::internal
4983 4984
4984 #endif // V8_TARGET_ARCH_MIPS 4985 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698