Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 96593005: MIPS: Fix --new-string-add feature. (Closed)

Created:
7 years ago by palfia
Modified:
7 years ago
Reviewers:
kisg, Paul Lind, kilvadyb, Yang, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix --new-string-add feature. This commit fixes the arguments of NewStringAdd stub in full-codegen. BUG= R=gergely@homejinni.com Committed: https://code.google.com/p/v8/source/detail?r=18166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
7 years ago (2013-11-29 13:21:00 UTC) #1
kisg
LGTM
7 years ago (2013-11-29 18:18:22 UTC) #2
palfia
7 years ago (2013-11-29 19:51:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698