Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 965543002: Remove the ability to shuffle page_sets from user_story_runner. (Closed)

Created:
5 years, 10 months ago by aiolos (Not reviewing)
Modified:
5 years, 10 months ago
Reviewers:
nednguyen, dtu, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the ability to shuffle page_sets from user_story_runner. BUG=454531 Committed: https://crrev.com/760237ae32340888443ac093a5f31db104ce98b9 Cr-Commit-Position: refs/heads/master@{#318361}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use filter for Dave! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -56 lines) Patch
M tools/telemetry/telemetry/page/page_set.py View 1 chunk +0 lines, -24 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner.py View 1 4 chunks +4 lines, -29 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
aiolos (Not reviewing)
5 years, 10 months ago (2015-02-26 22:02:51 UTC) #2
sullivan
lgtm This lgtm but you should probably wait for dtu and nednguyen as well in ...
5 years, 10 months ago (2015-02-26 22:07:53 UTC) #3
aiolos (Not reviewing)
On 2015/02/26 22:07:53, sullivan wrote: > lgtm > > This lgtm but you should probably ...
5 years, 10 months ago (2015-02-26 22:10:15 UTC) #4
nednguyen
On 2015/02/26 22:07:53, sullivan wrote: > lgtm > > This lgtm but you should probably ...
5 years, 10 months ago (2015-02-26 22:10:18 UTC) #5
dtu
lgtm % nit https://codereview.chromium.org/965543002/diff/1/tools/telemetry/telemetry/user_story/user_story_runner.py File tools/telemetry/telemetry/user_story/user_story_runner.py (right): https://codereview.chromium.org/965543002/diff/1/tools/telemetry/telemetry/user_story/user_story_runner.py#newcode202 tools/telemetry/telemetry/user_story/user_story_runner.py:202: if user_story_filter.UserStoryFilter.IsSelected(u)] user_stories = filter(user_story_filter.UserStoryFilter.IsSelected, user_story_set)
5 years, 10 months ago (2015-02-26 22:28:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965543002/20001
5 years, 10 months ago (2015-02-26 22:55:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-27 00:48:08 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-27 00:48:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/760237ae32340888443ac093a5f31db104ce98b9
Cr-Commit-Position: refs/heads/master@{#318361}

Powered by Google App Engine
This is Rietveld 408576698